This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Landscape integration into lighter than eyre #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't ready yet by the way. Collections do not work cross-ship yet. |
Cleaned up modulo/landscape boot relationship
Removed extraneous web files
Made collections json endpoint work
|
Cross-ship collections now work, this is ready for review |
|
Whoa.
—
~poldec-tonteg
http://urbit.org
…On Fri, Mar 29, 2019 at 3:23 PM ixv ***@***.***> wrote:
Cross-ship collections now work, this is ready for review
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1119 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABiQ4xC_o4VII73-8tJ1Lib_9uxnQtAiks5vbpJ9gaJpZM4cEbR0>
.
|
joemfb
suggested changes
Mar 29, 2019
eglaysher
suggested changes
Mar 29, 2019
eglaysher
approved these changes
Mar 29, 2019
| :: (trip 'window.onload = function() {') | ||
| "window.ship = '{+:(scow %p our.bow)}';" | ||
| "window.urb = new Channel();" |
joemfb
reviewed
Mar 29, 2019
sys/vane/rver.hoon
Outdated
| @@ -1340,6 +1338,7 @@ | |||
| =/ channel=(unit channel) | |||
| (~(get by session.channel-state.state) channel-id) | |||
| ?~ channel | |||
| ~& [%recieved-event-for-nonexistent-channel channel-id] | |||
joemfb
approved these changes
Mar 29, 2019
|
Catching breaking changes incrementally as they occur is a lot easier than
trying to dig for them all at once - generally, code review effort is
superlinear in the amount of code that needs to be looked at, because after
combination the information on what changes depend on each other vs don't
is rather involved to rederive.
…On Sun, Mar 31, 2019 at 11:02 PM Joe Bryan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/http.hoon
<#1119 (comment)>:
> @@ -0,0 +1,35 @@
+::
Perhaps a lib/client, to go with the lib/server added in this PR? In any
case worth noting that this PR (and the others targeting lighter-than-eyre)
are just finishing the development of lighter-than-eyre. There will be
final PRs here and on urbit/urbit, wherein the whole effort should receive
(any necessary) critical reviews.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1119 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABxXhh60rajpyN791X_-YQkB2fgEhO-Rks5vcaD0gaJpZM4cEbR0>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
cc @loganallenc