parse: add @uv and @uw support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Fang-
added a commit
to urbit/urbit
that referenced
this pull request
Jul 4, 2022
Updates the channel logic to communicate using jammed nouns, instead of json. It has been tested to actually work, but the "how do clients supply & handle nouns" story hasn't been fully fleshed out yet, so consider this a partial implementation. We hard-import nockjs, which has been extended with jso-to-noun utilities that we re-export. Arguments are taken as js values/objects, and passed through nockjs's dwim() function for conversion. This is sufficiently comfortable in most cases, but also slightly misleading. Nockjs should, sooner rather than later, be pulled out into its own repository and proper npm package. We should consider the relations between is, http-api, and aura-js. Also depends on aura-js including urbit/aura-js#3.
liam-fitzgerald
approved these changes
Jul 5, 2022
format: accept strings in place of bignums
xiphiness
pushed a commit
to xiphiness/urbit
that referenced
this pull request
Mar 14, 2023
Adds a "mode" to channels, which can be set to either %json (current behavior) or %jam. For %jam channels, aside from the SSE framing, all communication happens through @uw-encoded jammed nouns. This applies to both outgoing channel events, as well as incoming channel requests. We choose @uw-style encoding because raw bytestreams are fragile and cannot work inside the SSE stream context. Currently, a separate endpoint (/~/channel-jam/etc) is used to indicate %jam as the desired mode for a channel. We will probably want to make this a bit cleaner, not least because it's not currently implemented as a formal standalone endpoint, but also to give it stronger aesthetic equivalence with the existing channel endpoint. Putting the mode in the file extension is a tempting option here, but semantically not quite right. Connecting to the same channel across multiple modes is currently supported, but it's untested, and unclear whether this is desirable or not. http-api: use noun-based channels Updates the channel logic to communicate using jammed nouns, instead of json. It has been tested to actually work, but the "how do clients supply & handle nouns" story hasn't been fully fleshed out yet, so consider this a partial implementation. We hard-import nockjs, which has been extended with jso-to-noun utilities that we re-export. Arguments are taken as js values/objects, and passed through nockjs's dwim() function for conversion. This is sufficiently comfortable in most cases, but also slightly misleading. Nockjs should, sooner rather than later, be pulled out into its own repository and proper npm package. We should consider the relations between is, http-api, and aura-js. Also depends on aura-js including urbit/aura-js#3. webterm: update to work with noun-based channels We import the enjs utilities from nockjs and use those to parse incoming blits. eyre: deduce channel mode from headers, not url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactors their tests to match @da, and adds even larger test cases.
The dumb approach here of simply doing
alphabet.indexOfseems plenty fast. Checking and adjusting the value ofx.charAt(0)wasn't noticeably faster, and using a separate alphabet lookup table is actually a bit slower.CI is giving red Xs on master also, so I'm ignoring it. (;