bigint: use native bigint instead of big-integer #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it easier for our libraries to be used together, we are doing a pass over them, standardizing on using native bigint for big numbers. Nock-js already uses these. This library should follow. This commit updates all aura-js library code to use native bigints, and removed the big-integer dependency altogether.
size-limit report 📦
|
A fair chunk of the stuff it's throwing errors on right now is made worse by its suggestions. We could tweak it until it's good, but, not very many people working on this repo right now, and we can always police egregious style mishaps in PR review.
arthyn
approved these changes
Apr 16, 2024
test/aura.test.ts
Outdated
| const UV_PAIRS: [string, BigInteger][] = [ | ||
| ['0v16i', bigInt(1234)], | ||
| const UV_PAIRS: [string, bigint][] = [ | ||
| ['0v16i', 1234n], //TODO 1234n |
|
increment version! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier for our libraries to be used together, we are doing a pass over them, standardizing on using native bigint for big numbers. Nock-js already uses these. This library should follow.
This commit updates all aura-js library code to use native bigints, and removed the big-integer dependency altogether.
Not included is a version number bump. Since this changes the kinds of numbers we expose/ingest, this is a breaking API change.