Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"No accounts connected" for Firefox + Metamask + Ledger #1073

Closed
tomholford opened this issue Nov 14, 2022 · 2 comments · Fixed by #1075
Closed

"No accounts connected" for Firefox + Metamask + Ledger #1073

tomholford opened this issue Nov 14, 2022 · 2 comments · Fixed by #1075
Assignees
@tomholford

Comments

@tomholford
Copy link
Collaborator

tomholford commented Nov 14, 2022 •
edited

Even though the user has an account connected in MM, the extension returns an empty array when trying to get the connected accounts.

Luckily, Chromium functions as a workaround.

For context:

web+urbitgraph://group/~halbex-palheb/uf-public/graph/~halbex-palheb/general-4066/170141184505929554797657732808611725312
@tomholford
Copy link
Collaborator Author

With version 9.0.0 of the MetaMask browser extension, we stopped providing the window.web3 API to websites

https://metamask.zendesk.com/hc/en-us/articles/360053147012-MetaMask-Legacy-Web3

@tomholford tomholford self-assigned this Nov 17, 2022
tomholford added a commit that referenced this issue Nov 17, 2022
@tomholford
metamask: resolve connected accounts
e47013d 
This change adds the recommended approach to get a user's connected account address, as well as fallbacks for older versions of Metamask. This resolves #1073

See:

https://docs.metamask.io/guide/sending-transactions.html#example

https://metamask.zendesk.com/hc/en-us/articles/360053147012-MetaMask-Legacy-Web3
@tomholford tomholford mentioned this issue Nov 17, 2022
Merged
@vcavallo
Copy link

Just ran into this myself today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomholford tomholford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metamask: resolve connected accounts urbit/bridge
2 participants
@vcavallo @tomholford