WalletConnect: migrate to v2 #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntobin
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Looks good to me.
fwiw I had issues testing with my ledger, but this doesn't seem to be related to the implementation (possibly due to accessing via localhost?). Works fine on the other wallets I tested.
I assume whoever deploys will handle the VITE_WALLET_CONNECT_PROJECT_ID.
|
FYI WC v1 was sunsetted yesterday. Receiving feedback from users that they are no longer able to connect a wallet. Once tested, this change should be merged and deployed promptly. |
dillon
reviewed
Jul 12, 2023
|
going to be conflicts in the package-lock from recent merges, but also since eslint is fixed now, we should revisit this PR, it has a few errors that are worth fixing |
marcusmiguel
force-pushed
the
wcconnect-v2-migration
branch
from
5a910f4
to
9fba8e3
Compare
dillon
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1098
Should we deploy this already? Some wallets still uses v1 (e.g. MetaMask).
This expects a new
envvariable calledVITE_WALLET_CONNECT_PROJECT_ID, the project ID can be obtained from https://cloud.walletconnect.com/sign-in.