Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkKeys: note potential delay after cycling keys #1108

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

marcusmiguel
Copy link
Contributor

Resolves #1104

Displaying a waitMessage not only after the user has breached but also after a simple reset. Additionally, the content of the waitMessage has been updated to provide more accurate and useful information.

@jalehman jalehman requested a review from shawntobin May 29, 2023 13:48
Copy link
Contributor

@shawntobin shawntobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pkova
Copy link
Contributor

pkova commented Sep 8, 2023

@marcusmiguel the very first time someone accepts an L2 invite we have the following hack in place:

When they get their networking keys, they actually get two keys concatenated into one:

  1. The current networking key (belongs to the star).

  2. The key that is self-sovereign after the roller batch fires.

We do this so that people don't have to wait for the roller and are able to boot immediately. This does not apply on subsequent rekeys, so we need to make sure this message is only visible on subsequent rekeys and not the initial activation flow.

@pkova
Copy link
Contributor

pkova commented Sep 11, 2023

On second thought I think this is fine. The activation flow is completely self-contained and does not enter Bridge proper at all. This screen is not going to be visible for first-time L2 activators.

@pkova pkova merged commit e7448a0 into master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating a new keyfile should note potential delay
3 participants