Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint / pre-commit hook #1112

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Fix eslint / pre-commit hook #1112

merged 3 commits into from
Jul 12, 2023

Conversation

dillon
Copy link
Contributor

@dillon dillon commented Jul 11, 2023

Missing eslint packages were causing pre-commit hooks to fail.

Fixing the linter also surfaced 2 errors, which were fixed so that things can commits can go through now without --no-verify.

@dillon dillon requested a review from tomholford July 11, 2023 23:03
@dillon dillon changed the title Fix/eslint Fix eslint / pre-commit hook Jul 11, 2023
tomholford
tomholford approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@tomholford tomholford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dillon dillon merged commit 0002780 into urbit:master Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomholford tomholford tomholford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dillon @tomholford