WalletConnect & Ledger bug fix #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with WalletConnect where Ledger Live tries to send the transaction upon signing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with WalletConnect where Ledger Live is expected to just sign the transaction, but instead also tries to send it.
Bridge was throwing the error "invalid serialized tx input" when trying to sign a transaction using Ledger Live via WalletConnect, as it was actually evaluating the transaction hash that was returned after Ledger Live had already sent it.
It seems the 'fakeSign' logic is in place for such circumstances, so I'm just making it use that approach instead. The user is now alerted that their transaction will be signed when sending.