Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put build dir contents into root of release zip #115

Merged
merged 2 commits into from Apr 16, 2019
Merged

Conversation

Fang-
Copy link
Member

@Fang- Fang- commented Apr 16, 2019

By cding into the build directory, and then adding the files in it to the zip, we can add it to the release root so that people won't have to use --directory build or equivalent when using the python script to host Bridge.

Sort of fixes #88.

@Fang- Fang- requested a review from jtobin April 16, 2019 20:15
Copy link
Contributor

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@Fang- Fang- merged commit d7c511b into master Apr 16, 2019
@Fang- Fang- deleted the simpler-release branch April 16, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions unclear
2 participants