Support flagging for discontinuity #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-johnson
reviewed
May 6, 2019
src/bridge/views/SetKeys.js
Outdated
| state={ state.discontinuity } | ||
| > | ||
| <div style={{cursor: 'pointer'}} onClick={ this.toggleDiscontinuity }> | ||
| { 'I have lost important off-chain data relating to this point and need to do a hard-reset. (For example, rebooting an Arvo ship.)' } |
There was a problem hiding this comment.
I feel like "hard reset" is better than "hard-reset", but not super important.
There was a problem hiding this comment.
You're probably right. I'll change it. Good to go otherwise? (:
Include label in CheckboxButton component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25. The copy was taken from @alexmatz's suggestion there. Let me know if we're still cool with the neutral-ish wording there.
(I'll try to work on a separate PR that merges clickable label into the
CheckboxButtoncomponent.)