Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Incorporate poke-proxy-hook #19

Closed
matildepark opened this issue Jun 2, 2020 · 5 comments
Closed

Incorporate poke-proxy-hook #19

matildepark opened this issue Jun 2, 2020 · 5 comments
Labels
priority: 2 Other tasks are contingent upon this task's completion. High leverage.
Projects
OS 1.5

Comments

@matildepark
Copy link
Contributor

matildepark commented Jun 2, 2020 •
edited

@matildepark matildepark added this to Inbox in OS 1.5 Aug 24, 2020
@urcades urcades moved this from Inbox to To Do in OS 1.5 Aug 24, 2020
@matildepark matildepark added priority: 2 Other tasks are contingent upon this task's completion. High leverage. priority: 3 Feature requests, quality of life improvements, and less well-defined tasks. and removed priority: 2 Other tasks are contingent upon this task's completion. High leverage. labels Aug 24, 2020
@urcades
Copy link
Member

urcades commented Aug 24, 2020

Adding link to current designs:

https://www.figma.com/file/i7ssONyMpqgW4f6FeKEmtj/OS2?node-id=7698%3A634

We're speaking specifically to the 'bookending' interfaces on the viewport's header and footer, indicating that the state of the channel is in a "loading" state.

A separate but related component to make note of is our current "Reconnecting" label that pops up in the header:

Screen Shot 2020-08-24 at 6 52 45 PM

It's likely we should generalize this component/label such that we can display general "thinking" or "spinner" components here.

@matildepark matildepark mentioned this issue Sep 1, 2020
Closed
@matildepark
Copy link
Contributor Author

We can have a double pending state (sent vs. delivered).

@matildepark
Copy link
Contributor Author

If we write "lib/poke-proxy-hook" — When we poke remote, we'll poke it through some hook and it'll blindly pass on the poke to the remote; but we don't have any machinery in place to say "we submitted this and haven't heard from remote" or to surface that a remote declined.

@matildepark matildepark changed the title Research and execute multiple loading indicators Incorporate poke-proxy-hook Oct 20, 2020
@matildepark matildepark added priority: 2 Other tasks are contingent upon this task's completion. High leverage. and removed priority: 3 Feature requests, quality of life improvements, and less well-defined tasks. labels Oct 20, 2020
@matildepark matildepark moved this from To Do to In progress in OS 1.5 Dec 9, 2020
@matildepark matildepark moved this from In progress to In review in OS 1.5 Dec 10, 2020
@matildepark
Copy link
Contributor Author

urbit/urbit#4106, some other proxy work and conversations in urbit/urbit#4268

@liam-fitzgerald
Copy link
Member

Closing in favour of implementing remote pokes in eyre

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority: 2 Other tasks are contingent upon this task's completion. High leverage.
Projects
No open projects
OS 1.5
  
In review
Milestone
No milestone
Development

No branches or pull requests
3 participants
@urcades @matildepark @liam-fitzgerald