Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generateOwnershipWallet for shallowly generating a wallet #65

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

Fang-
Copy link
Member

@Fang- Fang- commented Jun 4, 2019

This is useful for the case where we only care about the ownership wallet/address, such as when generating temporary wallets for invites and similar flows. This saves us some computation time on parts of the wallet we don't care about.

@Fang- Fang- requested a review from jtobin June 4, 2019 14:30
@vvisigoth
Copy link
Contributor

vvisigoth commented Jun 4, 2019 via email

Copy link
Contributor

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one bru. I ran a hacky benchmark just for curiosity and it appears to shave off about ~400ms.

@jtobin jtobin merged commit 069bcbf into master Jun 5, 2019
@jtobin jtobin deleted the shallow-wallet branch June 5, 2019 00:10
@jtobin
Copy link
Contributor

jtobin commented Jun 5, 2019

(Released in v0.16.0 on npm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants