term: do not enable mouse reporting #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The style of mouse reporting we want, "mouse clicks only", appears to not be supported in any common terminal emulator. Worse, in xterm, that mode ends up preventing the user from scrolling the buffer. Until such a time where we can handle _all_ mouse inputs gracefully, we will refrain from taking mouse clicks in real terminals.
mcevoypeter
approved these changes
Jan 13, 2023
|
Once merged, we should deploy this to edge, and then move it over to release to deploy to soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The style of mouse reporting we want, "mouse clicks only", appears to not be supported in any common terminal emulator. Worse, in xterm, that mode ends up preventing the user from scrolling the buffer.
Until such a time where we can handle all mouse inputs gracefully, we will refrain from taking mouse clicks in real terminals.
Closes #109. h/t @ashelkovnykov for spotting the xterm problem.