Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger workflows for any release activities #152

Merged

Conversation

matthew-levan
Copy link
Contributor

@matthew-levan matthew-levan commented Jan 20, 2023

Resolves #150. See the GitHub docs for additional context.

If you take a look at all of the workflow files of the jobs (linked in #150) which were triggered by release activities, you can see that only feature workflows were triggered since it was the only workflow that included release: null in its on map.

Accordingly, it seems like all we have to do to ensure workflows are not triggered on any release activity is omit the release item from the on list in all of the workflow files.

Copy link

@mcevoypeter mcevoypeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you remove the unnecessary release: types: [] trigger in release.yml, it'll be good to merge. Note that CI is failing due to #148, so once #149 gets merged, rebase on top develop, and CI should pass.

.github/workflows/feature.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@matthew-levan
Copy link
Contributor Author

Once you remove the unnecessary release: types: [] trigger in release.yml, it'll be good to merge. Note that CI is failing due to #148, so once #149 gets merged, rebase on top develop, and CI should pass.

Thank you. I'll rebase once #149 is merged, probably next week. Then we can re-evaluate #57.

@mcevoypeter
Copy link

#149 just merged.

@matthew-levan matthew-levan force-pushed the i/150/dont-trigger-ci-on-releases branch from 3d2439d to 54539a4 Compare January 20, 2023 22:26
@matthew-levan
Copy link
Contributor Author

Ok, rebase is done. Please feel free to approve and merge @mcevoypeter. Have an excellent weekend!

@mcevoypeter mcevoypeter merged commit e69cc5b into urbit:develop Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a GitHub release unexpectedly triggers CI
2 participants