Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insert live into the PACE file during binary upload step #205

Merged
merged 1 commit into from Feb 7, 2023
Merged

insert live into the PACE file during binary upload step #205

merged 1 commit into from Feb 7, 2023

Conversation

matthew-levan
Copy link
Contributor

Resolves #204.

mcevoypeter
mcevoypeter previously approved these changes Feb 7, 2023
View reviewed changes
@matthew-levan matthew-levan changed the base branch from develop to release February 7, 2023 19:16
@matthew-levan matthew-levan dismissed mcevoypeter’s stale review February 7, 2023 19:16

The base branch was changed.

@matthew-levan matthew-levan changed the base branch from release to develop February 7, 2023 19:17
@matthew-levan
Copy link
Contributor Author

@mcevoypeter sorry I accidentally changed the base branch for the PR, will you please re-approve?

@matthew-levan
Copy link
Contributor Author

After this is merged, we should cherry-pick the commit onto the release branch so we have the code for the next release process (which means we won't have to worry any more about where the live binaries get uploaded to in our gcloud account).

@matthew-levan matthew-levan merged commit ac3e191 into urbit:develop Feb 7, 2023
matthew-levan added a commit to matthew-levan/vere that referenced this pull request Feb 10, 2023
@matthew-levan
insert live into the PACE file during binary upload step (urbit#205)
bd709e6
@matthew-levan matthew-levan mentioned this pull request Feb 10, 2023
Closed
jalehman added a commit that referenced this pull request Feb 13, 2023
@jalehman
insert live into the PACE file during version string upload (#205) (
3d16fee 
#217)

Resolves #215.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcevoypeter mcevoypeter mcevoypeter approved these changes

@jalehman jalehman Awaiting requested review from jalehman

@belisarius222 belisarius222 Awaiting requested review from belisarius222

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binaries uploaded to the live gcloud bucket contain erroneous short SHAs in version strings
2 participants
@matthew-levan @mcevoypeter