Clarify release instructions #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belisarius222
approved these changes
Feb 22, 2023
mcevoypeter
reviewed
Feb 27, 2023
| - [ ] `git checkout master` | ||
| - [ ] `git reset --hard origin/master` | ||
| - [ ] `git checkout -b merge-master-v{version}-into-develop` | ||
| - [ ] `git push origin merge-master-v{version}-into-develop` |
There was a problem hiding this comment.
Does this work? Assuming origin/merge-master-v{version}-into-develop doesn't already exist, I would think you'd need to specify -u/--set-upstream here.
There was a problem hiding this comment.
I think you're right @mcevoypeter. We'll test these instructions when we release today and update accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #246.