Restore ability to build Vere while using NixOS #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midlyx-hatrys
requested review from
mcevoypeter,
matthew-levan,
jalehman,
belisarius222 and
a team
as code owners
midlyx-hatrys
force-pushed
the
develop
branch
from
c7b742f
to
6469725
Compare
|
Cool, thanks for opening this. I'm sure some folks will be happy to use it.
|
Having "libtoolize --copy --force" first thing in "autogen.sh" is a totally normal thing people do, it is supposedly harmless and idempotent, no idea why lack thereof is apparently only problematic on NixOS. So: when running on NixOS, libtoolize.
Bazel on NixOS is problematic -- it's packaged, but not patched to actually _work_ outside of FHS environments. Vere build system presents an additional accidental hurdle: it expects the musl-cross-make toolchain to be under /usr/local/<target> and uses sudo to install it there, as one does. Unfortunately NixOS nerfs sudo in user namespaces (which are used to implement FHS environments) for security reasons, making it impossible to install the toolchain the normal way. So in order to restore the ability to build Vere under NixOS without resorting to containers (which is unsporting), this commit adds a flake, which defines a devshell, which provides the toolchain and all the other needed tools. So one can "nix develop", go get coffee (first invocation may take 15 minutes or so, subsequent ones will be instant until next nix store GC), and then "bazel build :urbit" etc.
Did the proper conservative thing and confined this change specifically to NixOS, thanks! |
matthew-levan
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(After the move to Bazel took it away)
Can build, can run tests (which all even pass), can create usable compile_commands.json, yay.
(To be clear: this makes it possible to use Bazel to build Vere under NixOS, it does not reintroduce the Nix-based build system or anything like that)