Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run fake ship tests under gc #334

Merged
merged 1 commit into from Apr 11, 2023

Conversation

matthew-levan
Copy link
Contributor

@matthew-levan matthew-levan commented Apr 6, 2023

Adds --gc to the boot phase of the fake ship tests as the binary we build for them already uses the correct copts.

Resolves #332.

@matthew-levan matthew-levan requested a review from a team as a code owner April 6, 2023 10:19
@matthew-levan matthew-levan added the ci Related to the continuous integration workflows label Apr 6, 2023
@barter-simsum
Copy link
Member

When I tried to boot an existing pier with the full debug binary, it just printed a bunch of hex addresses and eventually a "boot failed". Is this normal behavior?

No. --config=dbg only optimizes at -O0 and turns on c3_dessert debug asserts.

@barter-simsum
Copy link
Member

barter-simsum commented Apr 6, 2023

@matthew-levan can you confirm this behavior? This might be expected if the pier was built with U3_MEMORY_DEBUG or U3_CPU_DEBUG and you tried running on a binary without those options. Or if you passed those options when trying to rerun the pier and it wasn't built with those options. But this isn't at all expected for just --config=dbg

--config=dbg isn't a full debug configuration and we shouldn't be running it in ci because the unoptimized binary is quite a bit slower.

@matthew-levan matthew-levan force-pushed the i/332/add-gc-to-fake-ship-tests branch from 721f7a8 to 4d2d401 Compare April 11, 2023 14:42
@matthew-levan
Copy link
Contributor Author

Ok, so to recap: we just needed to add --gc to the boot phase of the fake ship tests.

@barter-simsum
Copy link
Member

lftm. approved

@matthew-levan matthew-levan merged commit b8d4f81 into develop Apr 11, 2023
5 checks passed
@matthew-levan matthew-levan deleted the i/332/add-gc-to-fake-ship-tests branch April 11, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to the continuous integration workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fake-ship tests are not run under gc
2 participants