Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Docker build and README #336

Merged
merged 2 commits into from Apr 10, 2023
Merged

Conversation

ashelkovnykov
Copy link
Contributor

  • Updates README (here and in DockerHub)
  • Fixes bug that posted README updates to tloncorp/urbit instead of tloncorp/vere
  • Moves DockerHub deploy tasks in build to separate workflow
  • Adds a workflow which allows on-demand GitHub Action to redeploy Docker image to DockerHub

@mopfel-winrux
Copy link
Contributor

Can we also include click.sh in the docker container? It would make maintaining piers a lot easier

@ashelkovnykov
Copy link
Contributor Author

ashelkovnykov commented Apr 7, 2023

@mopfel-winrux I'm not sure what the best way to do that is. The plan was to move the click stuff to a separate tools repo, but that becomes an issue if we want to do both:
a) build a new Docker image for each commit
b) include click in that Docker image

@mopfel-winrux
Copy link
Contributor

@ashelkovnykov hmm yea that is a conflict. I think if we're going to try and deprecate %lens it would make sense to include instructions either how to side-load click into the docker container through the volume, or to include it in it. I'm fine with either. NP sideloads scripts regularly into docker containers.

@ashelkovnykov ashelkovnykov merged commit 99cf3fe into urbit:develop Apr 10, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants