Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix macos-x86_64-specific build/test clang versions #338

Merged
merged 3 commits into from Apr 10, 2023
Merged

ci: fix macos-x86_64-specific build/test clang versions #338

merged 3 commits into from Apr 10, 2023

Conversation

matthew-levan
Copy link
Contributor

Resolves #337.

@matthew-levan matthew-levan requested a review from a team as a code owner April 8, 2023 03:37
@matthew-levan matthew-levan changed the title ci: remove macos-x86_64-specific build/test logic ci: fix macos-x86_64-specific build/test clang versions Apr 8, 2023
mcevoypeter
mcevoypeter previously approved these changes Apr 10, 2023
View reviewed changes
@ashelkovnykov
Copy link
Contributor

@matthew-levan @mcevoypeter Can one of you leave a quick comment about the changes:

  • why downgrade to 14.0.0 in the workflow
  • why mismatch between workflow and Bazel (14 vs 15)

@mcevoypeter
Copy link

The path to brew-installed LLVM headers changed, which requires an update to the sys_includes attribute of the brew-clang-macos-x86_64-config cc_toolchain_config target. The --clang_version was erroneously specified as 14.0.6 before, when it needs to be 15.0.7. Interestingly, an incorrect version supplied to the compiler_version attribute of brew-clang-macos-x86_64-config doesn't seem to have had a negative impact. I've updated the --clang_version to match the LLVM install (15.0.7) anyway.

@ashelkovnykov ashelkovnykov merged commit a201555 into develop Apr 10, 2023
5 checks passed
@ashelkovnykov ashelkovnykov deleted the i/337/macos-x86_64-ci-fix branch April 10, 2023 16:52
@matthew-levan
Copy link
Contributor Author

What happened here @mcevoypeter and @ashelkovnykov is that GitHub updated their macos-12 hosted runner image, thereby removing clang version 14.0.6 and adding version 15.0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashelkovnykov ashelkovnykov ashelkovnykov approved these changes

@mcevoypeter mcevoypeter mcevoypeter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated clang version for macos-x86_64 CI
3 participants
@matthew-levan @ashelkovnykov @mcevoypeter