Skip to content

Commit

Permalink
Merge pull request #1 from urbn/seriouslysean/urbn-fork-updates
Browse files Browse the repository at this point in the history
Update package for urbn ownership
  • Loading branch information
seriouslysean committed Jul 18, 2022
2 parents 40a3ae1 + 86979f1 commit a0596ba
Show file tree
Hide file tree
Showing 4 changed files with 6,183 additions and 11 deletions.
56 changes: 56 additions & 0 deletions .github/workflows/pr-actions.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
name: PR Checks

# Run on pull requests to main
on:
pull_request:
branches:
- main
# Defaults + ready_for_review to trigger a re-run when a Draft PR is converted to a normal PR
# See: https://github.community/t/dont-run-actions-on-draft-pull-requests/16817/17
types: [opened, synchronize, reopened, ready_for_review]

permissions:
contents: read
pull-requests: read

# Only allow one build per PR source branch to run at once, cancelling in-progress
# builds when new builds arrive
# See: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idconcurrency
concurrency:
group: ${{ github.head_ref }}
cancel-in-progress: true

# Define the separate jobs to run
jobs:
# Checks if the PR is in draft status and fails if so, which does 2 things:
# - Prevents the PR from being merged in that state
# - Prevents all downstream jobs from running
draft:
name: "Check Draft Status"
runs-on: ubuntu-latest
steps:
- name: "Fail draft PRs"
if: github.event.pull_request.draft == true
run: |
echo "Skipping execution for draft PR"
exit 1
- run: echo "PR is not Draft"

test:
name: "Check Linting & Tests"
needs: draft
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v2
- name: set node version
uses: actions/setup-node@v3
with:
node-version: "16.13.2"
cache: 'npm'
- name: install node modules
run: npm ci
- name: run linting
run: npm run lint
- name: run tests
run: npm run test
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

A Webpack plugin to be used in conjunction with [vue-loader] to assist in generating themed builds of a [Vue.js] application.

* [Getting Started](#getting-started)
* [Getting Started](#getting-started)
* [Use case](#use-case)
* [Example](#example)
* [Contributing](#contributing)
Expand Down Expand Up @@ -172,7 +172,7 @@ Let's alter the `<style>` sections of our component to use the `vue-themed-style
</style>
```

Now, add the loader to your webpack config. It is important to note that because all webpack loaders are run from right-to-left (see [Pitching Loaders][pitching-loaders], the `vue-themed-style-loader` must be specified _after_ the `vue-loader`. this ensures it will execute _before_ the `vue-loader` to discard inactive themed style sections.
Now, add the loader to your webpack config. It is important to note that because all webpack loaders are run from right-to-left (see [Pitching Loaders][pitching-loaders], the `vue-themed-style-loader` must be specified _after_ the `vue-loader`. this ensures it will execute _before_ the `vue-loader` to discard inactive themed style sections.

Here's an example `webpack.config.js`:

Expand Down Expand Up @@ -280,7 +280,7 @@ Contributions and Pull Requests are welcome! Or if you find something wrong, pl

## Versioning

This repository uses [SemVer] for versioning. For the versions available, see the [releases on this repository][releases].
This repository uses [SemVer] for versioning. For the versions available, see the [releases on this repository][releases].


## License
Expand All @@ -290,15 +290,15 @@ This project is licensed under the MIT License - see the [LICENSE] file for deta

## Acknowledgments

* This would not be possible without [Webpack] and [Vue.js].
* This would not be possible without [Webpack] and [Vue.js].
* Notably, the [vue-template-compiler] module
* This work was inspired by some of the interesting work we're doing over at [URBN]


[Node]: https://nodejs.org/en/
[LICENSE]: LICENSE
[LICENSE]: LICENSE
[pitching-loaders]: https://webpack.js.org/api/loaders/#pitching-loader
[releases]: https://github.com/brophdawg11/vue-themed-style-loader/releases
[releases]: https://github.com/urbn/vue-themed-style-loader/releases
[SemVer]: http://semver.org/
[Vue.js]: https://vuejs.org/
[vue-loader]: https://github.com/vuejs/vue-loader/
Expand Down
Loading

0 comments on commit a0596ba

Please sign in to comment.