Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

django-letsencrypt allows multiple, equal challenge values -- MultipleObjectsReturned #2

Closed
urda opened this issue Nov 24, 2016 · 1 comment
Closed

django-letsencrypt allows multiple, equal challenge values -- MultipleObjectsReturned #2

urda opened this issue Nov 24, 2016 · 1 comment
Assignees
@urda
Labels
bug

Comments

@urda
Copy link
Owner

urda commented Nov 24, 2016 

MultipleObjectsReturned at /.well-known/acme-challenge/CHALLENGE_TEXT

get() returned more than one AcmeChallenge -- it returned 2!
@urda urda added the bug label Nov 24, 2016
@urda urda self-assigned this Nov 24, 2016
@urda
Copy link
Owner Author

urda commented Nov 24, 2016

A few thoughts on this matter:

  • Option A:
    • Convert challenge to be the primary key. This would then make it a charfield.
    • Drop the current id column on the model.
    • Handle in the migration duplicate records (keep oldest if different response values).
  • Option B:
    • Convert challenge to a unique=True type of field.
    • Handle in the migration duplicate records.

@urda urda changed the title MultipleObjectsReturned django-letsencrypt allows multiple, equal challenge values -- MultipleObjectsReturned Nov 24, 2016
@urda urda added this to the v1.0.2 milestone Nov 24, 2016
@urda urda mentioned this issue Nov 25, 2016
Merged
8 tasks
@urda urda closed this as completed in #3 Nov 25, 2016
urda added a commit that referenced this issue Nov 25, 2016
@urda
Merge branch 'bugfix/gh-2'
b9997f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urda urda

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@urda