Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Django version first, then requirements in Travis #54

Closed
wants to merge 2 commits into from

Conversation

michael-k
Copy link
Contributor

@michael-k michael-k commented Dec 9, 2017

This PR installs the specific Django version first, before installing requirements.txt. This means Travis will no longer install whatever Django version first, and instead will look something like:

$ pip install Django==$DJANGO_VERSION
Collecting Django==1.8.18
  Downloading Django-1.8.18-py2.py3-none-any.whl (6.2MB)
    100% |████████████████████████████████| 6.2MB 262kB/s 
Installing collected packages: Django
Successfully installed Django-1.8.18

$ pip install -r requirements.txt
Requirement already satisfied: Django in /home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages (from -r requirements.txt (line 3))

@codecov
Copy link

codecov bot commented Dec 9, 2017

Codecov Report

Merging #54 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #54   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            3      3           
  Lines           23     23           
======================================
  Hits            23     23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2bf58...5cd9f00. Read the comment docs.

@urda
Copy link
Owner

urda commented Dec 10, 2017

Hey!

I wanted to drop in and say THANKS for the contribution.

I’m on the road for now, but this week I’ll try to get a review in for this later this week. I also have a local branch with similar changes to compare with first so I’m not sure if this is already covered already.

Thanks again, and I’ll get back to this shortly.

@urda urda changed the base branch from master to develop December 23, 2017 16:15
@urda urda changed the title Adds support for Django 2.0, drops support for Django 1.10 Install Django version first, then requirements in Travis Dec 23, 2017
@urda
Copy link
Owner

urda commented Dec 23, 2017

Hi @michael-k , I'm going to hold off on the Django version bump as I already have a local branch I'm working on to support it. It was also dropping support for another version, and I normally do not like doing two different tasks like that in a single PR.

HOWEVER I do love you fixed up travis to install the Django version first. I'm signing that commit, and preparing this for a merge.

@urda
Copy link
Owner

urda commented Dec 23, 2017

Restored old commits to this PR, closing in favor of #55

@urda urda closed this Dec 23, 2017
@michael-k michael-k deleted the django-2.0 branch December 24, 2017 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants