Integrate with urfave/cli/v3 APIs #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearchap
reviewed
Jun 23, 2023
dearchap
reviewed
Jun 23, 2023
dearchap
reviewed
Jun 23, 2023
dearchap
reviewed
Jun 23, 2023
dearchap
reviewed
Jun 23, 2023
| return nil | ||
| } | ||
|
|
||
| func ExampleYAML() { |
There was a problem hiding this comment.
You can collapse the code in these 3 examples with a
setupApp(ValueSources..) convenience method.
That way all the examples have to do is pass in the value sources and rest remains the same.
There was a problem hiding this comment.
I was hesitant to abstract too much of it because the bodies of these will appear in godoc documentation but without the setup code or abstracted/shared code 🤔
dearchap
reviewed
Jun 23, 2023
| } | ||
|
|
||
| func unmarshalMap(i any) (ret map[any]any, err error) { | ||
| ret = make(map[any]any) |
There was a problem hiding this comment.
idk; this was a move too 🤔 I was thinking I'd avoid changing the implementation at this time but I can!
dearchap
reviewed
Jun 23, 2023
dearchap
approved these changes
Jun 23, 2023
|
@meatballhat That was some nice piece of works. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a library replacement, given that none of the
InputSourceContextand flag type wrappers were working without modification and the more recentValueSourceAPI in urfave/cli/v3 allows for a much simpler (imho) integration.Closes #5