Omitted optional arg uses the given value

urfave · Feb 11, 2024 · 6070e61 · 6070e61
1 parent f7deded
commit 6070e61
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/args.go b/args.go
@@ -132,8 +132,12 @@ func (a *ArgumentBase[T, C, VC]) Parse(s []string) ([]string, error) {
 		*a.Values = values
 	}
 
-	if a.Max == 1 && a.Destination != nil && len(values) > 0 {
-		*a.Destination = values[0]
+	if a.Max == 1 && a.Destination != nil {
+		if len(values) > 0 {
+			*a.Destination = values[0]
+		} else {
+			*a.Destination = t
+		}
 	}
 	return s[count:], nil
 }

diff --git a/args_test.go b/args_test.go
@@ -168,6 +168,6 @@ func TestSingleOptionalArg(t *testing.T) {
 	require.Equal(t, "", s1)
 
 	arg.Value = "bar"
-	require.NoError(t, cmd.Run(context.Background(), []string{"foo", "bar"}))
+	require.NoError(t, cmd.Run(context.Background(), []string{"foo"}))
 	require.Equal(t, "bar", s1)
 }