Skip to content
Permalink
Browse files

Merge latest master into v2-merge-master

commit c71fbcefd21552b70cd625b2c54466006e258ad7
Merge: 61f3ae3 ef47250
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Sep 12 05:35:50 2019 +0530

    Merge pull request #887 from urfave/asahasrabuddhe-patch-1

    Release 1.22.1

commit ef47250cda5ff52a313118c01ad6b0c5b4877a70
Merge: 71eaf37 61f3ae3
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Sep 12 05:19:58 2019 +0530

    Merge branch 'master' into asahasrabuddhe-patch-1

commit 61f3ae353bf455e3522aff0d5a28be9278bba7f2
Merge: 388c2dd fa858dc
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Sep 12 05:19:33 2019 +0530

    Merge pull request #890 from urfave/issue-878

    Fix #878

commit fa858dcc260fb07c25aab13650d9fa0e64f851c7
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Sep 11 15:10:14 2019 +0530

    Ensure flag is not blank

commit f8bb66ae7d679973cf9b3f6f8c3dc6933404a31a
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Sep 11 14:42:38 2019 +0530

    Fix Typo

commit 056aef13fe0b0e51403036ca5527854f50a1f3cd
Merge: c6ee3b4 82a84fc
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Sep 11 14:37:06 2019 +0530

    Merge branch 'issue-878' of https://github.com/urfave/cli into issue-878

commit c6ee3b4904ed76d34f277c315c2097ae7b22d38f
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Sep 11 14:34:41 2019 +0530

    Use iterative logic to determine missing flag

commit 82a84fc187c23434a5c2e1398a7fcfbc9c51df94
Merge: 1547ac2 388c2dd
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 14:17:11 2019 +0530

    Merge branch 'master' into issue-878

commit 1547ac2f6a3d3d39fe4d49570c0d1c2401a8f20e
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Sep 11 14:15:20 2019 +0530

    Modify variable names

commit 388c2dd0f4ffaa8541e371d49c8413870a04d9fe
Merge: e19126a 6d888d6
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 14:13:40 2019 +0530

    Merge pull request #891 from saschagrunert/fish-hidden

    Don't generate fish completion for hidden commands

commit 71eaf37e337d5daea12c6a137113c71056151530
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 14:09:50 2019 +0530

    Update CHANGELOG.md

commit 6d888d693d81e13806356854c57574334d9ef3b9
Merge: bac5bde e19126a
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 14:04:44 2019 +0530

    Merge branch 'master' into fish-hidden

commit e19126a8198a7c076339e69ed4d372567750dd24
Merge: b207e20 35eb598
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 14:01:44 2019 +0530

    Merge pull request #883 from urfave/remove-flag-generation

    Remove flag generation

commit bac5bde38c7725990645cf9b2bf2c824594f3963
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Wed Sep 11 09:06:02 2019 +0200

    Don't generate fish completion for hidden commands

    Added the missing test case as well.

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 36cdaa9964df03e2b8f8d2147a99497536851ad9
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 10:34:00 2019 +0530

    Update CHANGELOG.md

commit cbb9e015b89225aa090c41085bdb0933f6290d96
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 09:21:45 2019 +0530

    Improve Code and Add Test Case

commit 7d6a604106e44732edc0a76f4a4800c8c27ddfbe
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 08:59:51 2019 +0530

    Fix #878

commit be37c2cbda3ba6a37fa8f7a0df960de844afc843
Merge: 0aee120 b207e20
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 08:27:45 2019 +0530

    Merge branch 'master' into asahasrabuddhe-patch-1

commit 35eb598d43c3ab639e3c0ccc72e37f294e5b5828
Merge: 8575558 b207e20
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 05:39:35 2019 +0530

    Merge branch 'master' into remove-flag-generation

commit 0aee120c32003fff6f320c2a00a41d03285fdde0
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 05:37:41 2019 +0530

    Update CHANGELOG.md

commit 5c019b10ca37c1a0b74b637d3b0aa25dfeb0110f
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Sep 11 05:33:46 2019 +0530

    Update CHANGELOG.md

commit b207e20873f5805e7c9cc544b3418a0a3ec63e09
Merge: 249cb33 487be14
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Tue Sep 10 21:28:35 2019 +0100

    Merge pull request #889 from crosbymichael/hidden-man

    Don't output hidden commands for  man pages

commit 487be14dceb185a3321cacd9bf302f5e811f5ee8
Author: Michael Crosby <crosbymichael@gmail.com>
Date:   Tue Sep 10 13:49:11 2019 -0400

    Don't output hidden commands for  man pages

    Signed-off-by: Michael Crosby <crosbymichael@gmail.com>

commit 85755588ac06f74702bf7d62802dab0655881182
Merge: 024692c 249cb33
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 15:04:12 2019 +0530

    Merge branch 'master' into remove-flag-generation

commit 249cb3339254361b1a884733a98d4202e2838b9b
Merge: bfe2e92 abfb13b
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Tue Sep 10 08:28:09 2019 +0100

    Merge pull request #885 from urfave/go-modules-support

    Go modules support

commit abfb13b8542fbe3d542d46543ab0d3be6aacb4e5
Merge: 534d60b bfe2e92
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 06:56:41 2019 +0530

    Merge branch 'master' into go-modules-support

commit 054fbefec36cad7425dc6f4cfb6d2963c2710751
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 06:42:34 2019 +0530

    Update CHANGELOG.md

commit 534d60bb9bb0476141540ec77c5a3d51e176d162
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 06:40:45 2019 +0530

    Bump minimum supported version of Go to 1.11

commit 024692c172f7000fe2431c3280a1e4b724b15945
Merge: 4a9e440 bfe2e92
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 06:33:21 2019 +0530

    Merge branch 'master' into remove-flag-generation

commit bfe2e925cfb6d44b40ad3a779165ea7e8aff9212
Merge: 3eca109 238c80f
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Tue Sep 10 06:24:10 2019 +0530

    Merge pull request #882 from urfave/lynncyrin-patch-1

    Release 1.22.0

commit 426e21c150d9a33e4d8c13c2a13c5234e85f3a0e
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 13:15:47 2019 +0530

    Update .travis.yml

    Set GOPROXY in Travis environment

commit 39bd6176649871817d1966b6b91f042be4b62fe9
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 08:37:16 2019 +0530

    Cleanup after before_script to avoid git diff errors
    remove windows build

commit edbf66c25cf83541faee77d0064fdb5ac35a51b1
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 08:23:04 2019 +0530

    Update gfmrun import command to suite Go Modules pattern
    Fix test command typo in travis script

commit afd0ecbbf2fbda2f9459046228ccc9e8d2693258
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 08:19:06 2019 +0530

    Add support for Go 1.13
    Drop support for Go 1.11
    Use md2man v2 to avoid dependency issues when building with Go Modules
    Enabled
    Update TravisCI build environment images (trusty was deprecated)
    Add optional Windows build

commit 4a9e440503f4113a351322da93f8630df14dfcaa
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 08:12:09 2019 +0530

    Fix AppVeyor build

commit 5c81af9f10b974cecbec6e20e4976574e86fc78b
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 07:47:18 2019 +0530

    Remove generate script from travis flow
    Remove unused dependencies from travis script

commit b6c5d17a835d17e8dd8f2e34c02e96af7f43c9e4
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Mon Sep 9 07:44:07 2019 +0530

    Remove Flag Generation
    Remove Legacy Python Scripts

commit 238c80f9b5e54a834f25423fd0887f68b9737cbb
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Sep 7 20:44:48 2019 -0700

    Update CHANGELOG.md

commit 980742b7cc56e8f7b14b4668fb8ddcf89025c9ea
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Sep 7 20:43:56 2019 -0700

    typo

commit 890d49ca7a15a3fb7f44d33e5cdb499f0e5c2331
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Sep 7 20:41:44 2019 -0700

    Release 1.22.0

    - adds the changelog for 1.22.0
    - updates the changelog for 1.21.0. some PRs were missed, as was mentioned here https://github.com/urfave/cli/pull/829#issuecomment-517968795
    - closes https://github.com/urfave/cli/issues/867

commit 3eca1090a37a65fea5b84bdbd2c61f8104211b74
Merge: 38a6c56 4bbff84
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Fri Aug 30 15:53:55 2019 +0100

    Merge pull request #879 from saschagrunert/escape-single-quotes

    Escape single quotes in fish shell completion

commit 4bbff841690954ed86c147147151c0144dcf1765
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Thu Aug 29 14:45:32 2019 +0200

    Escape single quotes in fish shell completion

    Single quotes can break the generated fish shell completion and should
    be escaped correctly.

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 38a6c560b3b8ac6d47e031a44b92e0531824c7e5
Merge: fa6797b 687f721
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 29 20:52:07 2019 +0100

    Merge pull request #857 from saschagrunert/takes-file-fish

    Add `TakesFile` to fish shell completion

commit 687f721eaa40859950820b37b9ad1fcd85b7da9f
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Mon Aug 26 10:07:50 2019 +0200

    Update function alignment

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 0c01922a12c501867cad200bc4b36a25f9a073e0
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Mon Aug 26 08:46:55 2019 +0200

    Add type switch

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 38d0ac629677a7fbf08a52e17fec73894bb31263
Author: Sascha Grunert <mail@saschagrunert.de>
Date:   Sun Aug 25 17:50:18 2019 +0200

    Removed GetTakesFile and stick to type assertions

    Signed-off-by: Sascha Grunert <mail@saschagrunert.de>

commit a1cf7f44b6cf65c0c10c282c71524cc37442b798
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Mon Aug 12 09:42:12 2019 +0200

    Add `TakesFile` to fish shell completion

    The new `TakesFile` flag will be now consumed by the fish shell
    completion generator.

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit fa6797beefc5727035323623aed515e4dfd3ccdf
Merge: 2344c98 82eb0d7
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 24 18:58:52 2019 -0700

    Merge pull request #876 from urfave/lynncyrin-patch-1

    Bump go version to 1.10 in readme

commit 82eb0d70cbcf89de5e71965fc9ededbb41cdbd96
Merge: edd8cb2 2344c98
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sun Aug 25 01:04:33 2019 +0100

    Merge branch 'master' into lynncyrin-patch-1

commit 2344c98f678ac236c6bf952fe724bc5b0a6bd69b
Merge: 55de011 68ee2bc
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sun Aug 25 01:04:17 2019 +0100

    Merge pull request #860 from saschagrunert/takes-file-not-all

    Update `TakesFile` flag to apply only to supported flags

commit edd8cb2068b6501d6b631299038cb42194926a8e
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 24 14:44:56 2019 -0700

    Bump go version to 1.10 in readme

    Closes https://github.com/urfave/cli/issues/875

commit 68ee2bc4af27ae14cedbfb881384b0900a0ed3a9
Merge: 959d9ec 55de011
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 24 14:34:15 2019 -0700

    Merge branch 'master' into takes-file-not-all

commit 55de011cf89b3d78842e3b3e2cf92f9d157fa399
Merge: 392c1de d3edef8
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sat Aug 24 11:55:28 2019 +0100

    Merge pull request #873 from urfave/show-test-failures

    build: show failures when running tests

commit d3edef887a2fc39830216cd41b16955ef60d0d3c
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sat Aug 24 11:34:03 2019 +0100

    Update build.go

commit c2d1a132082e3b02a219e61eeef49da364d2c315
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Aug 24 03:05:45 2019 -0700

    Revert "check length"

    This reverts commit 1095838cca9d596e55cff88bcb35b67cf83bf4e4.

commit 959d9ec36b7848004fd2e85f07b810266d65c8d2
Merge: 3681b05 392c1de
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Sat Aug 24 11:23:51 2019 +0200

    Merge branch 'master' into takes-file-not-all

commit 7d62a9d0547cbab68e78c2c92a79db97ee61f115
Merge: 1095838 392c1de
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 24 00:50:42 2019 -0700

    Merge branch 'master' into show-test-failures

commit 1095838cca9d596e55cff88bcb35b67cf83bf4e4
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Aug 24 00:49:29 2019 -0700

    check length

commit 29ad6ee6ad7e02dbec3334e8843bb6711c011b55
Author: [[ BOT ]] Lynn Cyrin <lynncyrin@gmail.com>
Date:   Fri Aug 23 20:09:08 2019 -0700

    DRY

commit 392c1de1a2b3f8bc2ca95c2389dd05469d347b14
Merge: 23c8303 487c723
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Fri Aug 23 22:51:39 2019 +0100

    Merge pull request #874 from saschagrunert/go-mod-cleanup

    Cleanup go modules

commit 487c7236736db7d5d2e46633d09453d0e149a0bd
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Fri Aug 23 10:28:32 2019 +0200

    Cleanup go modules

    These two dependencies are not really needed, which can be
    reproduced via:

    ```
    > export GO111MODULE=on && go mod tidy
    ```

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 8469a9de07c45435b61cbfd4aed7167fb9e59cca
Author: [[ BOT ]] Lynn Cyrin <lynncyrin@gmail.com>
Date:   Thu Aug 22 21:42:07 2019 -0700

    show test failures

commit 23c83030263f7adfc0e3c34b567ee508e8d536cf
Merge: ecd576e 6a25af9
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 17 11:24:05 2019 -0700

    Merge pull request #862 from russoj88/UpdateREADME_gopkg.in_v1

    Rewrite the "pinning to v1" section.

commit 6a25af96413deaeb4d6c451d6288079db0840a82
Merge: 3bc62c4 ecd576e
Author: russoj88 <russoj88@users.noreply.github.com>
Date:   Sat Aug 17 10:01:35 2019 -0700

    Merge branch 'master' into UpdateREADME_gopkg.in_v1

commit ecd576e779bce41496738b34e9ee6272c63801d0
Merge: 6cc7e98 e11183f
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sat Aug 17 16:51:43 2019 +0100

    Merge pull request #868 from urfave/lynncyrin-patch-1

    Modernize readme

commit e11183fe50e3b3d75e481b1262e3222c565ba8bf
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 17 02:44:49 2019 -0700

    Modernize readme

    I assume that people no longer care about what the package was named many years ago

commit 3bc62c4fde03e107cad02f8828780470258b8fc0
Author: russoj88 <russoj88@gmail.com>
Date:   Thu Aug 15 12:30:29 2019 -0700

    Mimic v2 example code from above.

commit 62b8a7cc2cb05b1a454908087b35e5780a1d12ad
Author: russoj88 <russoj88@gmail.com>
Date:   Wed Aug 14 11:20:09 2019 -0700

    Add "Using v1 releases" to table of contents.

commit cc091db561b137c49cbf370766a94b47cfdae182
Author: russoj88 <russoj88@users.noreply.github.com>
Date:   Wed Aug 14 11:21:40 2019 -0700

    Update README.md

    Only instruct on right way to use library.

    Co-Authored-By: Lynn Cyrin (they/them) <lynncyrin@gmail.com>

commit f529dad70caa6e307f95eecb2db6f16efc0f964d
Author: russoj88 <russoj88@users.noreply.github.com>
Date:   Wed Aug 14 11:20:58 2019 -0700

    Update README.md

    Include suggestion to put example in.

    Co-Authored-By: Lynn Cyrin (they/them) <lynncyrin@gmail.com>

commit f2c26bab772e6b69a9fca945534728678578eb2b
Author: russoj88 <russoj88@gmail.com>
Date:   Tue Aug 13 21:10:38 2019 -0700

    Rewrite the "pinning to v1" section.

commit 3681b057c5df7f380e75974674a8282cf5632dc3
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Tue Aug 13 09:43:57 2019 +0200

    Update `TakesFile` flag to apply only to supported flags

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 6cc7e987c4fa553caa5014c7dbc1e7acaea9f0f1
Merge: 7e49cc2 08c24e2
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Mon Aug 12 21:30:37 2019 +0100

    Merge pull request #856 from FaranIdo/master

    Add Subcommand fallback call to ExitErrHandler, fixing #816

commit 08c24e22ed2c4bebb348a738caf92c40bb63133c
Author: FaranIdo <idoosbron@gmail.com>
Date:   Mon Aug 12 00:29:46 2019 +0300

    add missing ExitErrHandler in command + matching test, fixing #816

commit 7e49cc210a231eec218c2fba82df106af06d05b5
Merge: 8b18c71 4e42a2f
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 10 09:01:16 2019 +0000

    Merge pull request #848 from saschagrunert/fish-shell

    Add fish shell completion support

commit 4e42a2f02ceb3cbfe2f8c4e5c6e419a712c335c9
Merge: 56d12d0 8b18c71
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 10 08:47:31 2019 +0000

    Merge branch 'master' into fish-shell

commit 8b18c71e1a4eabe8d7ba20d81d7fbd882709833d
Merge: 7058c58 c6c2008
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 10 08:47:23 2019 +0000

    Merge pull request #851 from saschagrunert/takes-file

    Add `TakesFile` indicator to flag

commit 56d12d0c2f27a159e95165cf3cec2396df6f68af
Merge: 7506b11 7058c58
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 9 17:21:24 2019 +0530

    Merge branch 'master' into fish-shell

commit c6c200864d770982106717a20ad99603396fb042
Merge: e9e9e0a 7058c58
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Fri Aug 9 13:48:36 2019 +0200

    Merge branch 'master' into takes-file

commit 7058c58eb6af9ee166dafdf82012e1241890223d
Merge: 2e0e39a de0fa70
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 9 17:16:13 2019 +0530

    Merge pull request #847 from saschagrunert/remove-date-var

    Remove unused `Date` variable from `cliTemplate`

commit de0fa704331adf0183d6f1b6d94a2390a48a810c
Merge: 0d79d1d 2e0e39a
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Fri Aug 9 12:38:50 2019 +0100

    Merge branch 'master' into remove-date-var

commit e9e9e0ac5dfce215fb2207b3bbde2534a67907f6
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Fri Aug 9 09:05:55 2019 +0200

    Add `TakesFile` indicator to flag

    This new member of `Flag` indicates if the flag expects a file as input.
    This is especially useful for documentation and shell completion purposes.

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 7506b11da746beef287831f805f5b0e49264b400
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Thu Aug 8 15:50:36 2019 +0200

    Add fish shell completion support

    This commit adds a new method `ToFishCompletion` to the `*App` which can
    be used to generate a fish completion string for the application.

    Relates to: #351

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit 2e0e39a03b46023f83ec2e70f1948836e0581543
Merge: 946f918 aed704a
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 9 10:34:28 2019 +0530

    Merge pull request #845 from urfave/lint-fixes

    linter fixes

commit 0d79d1d9d99db9e380e37034f677523b0ca435b5
Author: Sascha Grunert <sgrunert@suse.com>
Date:   Thu Aug 8 14:04:21 2019 +0200

    Remove unused `Date` variable from `cliTemplate`

    Signed-off-by: Sascha Grunert <sgrunert@suse.com>

commit aed704a9d036852c332867dffd97c60c51e8a38d
Merge: 0990ca2 946f918
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Aug 8 14:44:02 2019 +0530

    Merge branch 'master' into lint-fixes

commit 946f918365f62f6fe8d7fb7d4ea54dd441eccfb6
Merge: 2c477e7 286133f
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 8 09:13:09 2019 +0100

    Merge pull request #735 from rliebz/combined

    Add app-wide support for combining short flags

commit 0990ca2391ac8a72bc59d393e64ca520d9c53772
Merge: fdba7e0 2c477e7
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Aug 8 13:36:30 2019 +0530

    Merge branch 'master' into lint-fixes

commit 286133fee5ef662bcfc9fdb7e410ce83528ab1f8
Merge: 815c29f 2c477e7
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Thu Aug 8 13:33:32 2019 +0530

    Merge branch 'master' into combined

commit 2c477e720e69b9ce81e9d6cf68c81a0334446016
Merge: e0057bb 99fad61
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 8 08:41:19 2019 +0100

    Merge pull request #830 from saschagrunert/docs-gen

    Add markdown and man page docs generation methods

commit 99fad61ded52131321a0d7e5d330554512254ebe
Merge: 40d4a25 e0057bb
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 8 07:06:08 2019 +0100

    Merge branch 'master' into docs-gen

commit e0057bb59731900e8b702b0b5282378577cb99e5
Merge: 521735b fd39578
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 8 07:04:25 2019 +0100

    Merge pull request #846 from urfave/asahasrabuddhe-patch-1

    Update README.md

commit 815c29ffc73623b32e587298eeda0a0dd2ff5737
Merge: a77c440 521735b
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Thu Aug 8 07:03:49 2019 +0100

    Merge branch 'master' into combined

commit fd395786a2c77da3f111c6208ba50b3041fe6ee2
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 21:00:07 2019 +0530

    Update README.md

    remove quotes around coverage badge

commit fdba7e0f8c921d4ce169cb416b2eae58026c83e9
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Aug 7 20:14:50 2019 +0530

    linter fixes
    code cleanup
    changing some test code to ensure uniformity

commit 40d4a25a01296d2f51bf7bbf0b6e8eb99ba4a84c
Author: Sascha Grunert <mail@saschagrunert.de>
Date:   Sat Aug 3 12:41:50 2019 +0200

    Add markdown and man page docs generation methods

    This adds two new methods to the `App` struct:

    - `ToMarkdown`: creates a markdown documentation string
    - `ToMan`: creates a man page string

    Signed-off-by: Sascha Grunert <mail@saschagrunert.de>

commit 521735b7608a25d771a39d42e2267e061e7e84b8
Merge: 97179ca 22e1fc8
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Wed Aug 7 12:10:34 2019 +0100

    Merge pull request #844 from urfave/asahasrabuddhe-patch-1

    Update README.md

commit 22e1fc84192059f056a7b53aa5ef2ee7113d9a83
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 14:02:52 2019 +0530

    Update README.md

    add codecov.io badge

commit 97179ca390abf228a187e6ebbedca69636d60f0d
Merge: b6f7dd9 3a41d6d
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 13:58:51 2019 +0530

    Merge pull request #843 from lafriks/patch-1

    Support GoLang 1.10 to 1.12

commit 3a41d6d7851b15f132131444865e82b17baf0be0
Author: Lauris BH <lauris@nix.lv>
Date:   Wed Aug 7 11:21:31 2019 +0300

    Lower support to GoLang compiler version 1.10

commit 1f4473209dcad42ed88ba68f1be7d4e906ae91be
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 13:50:04 2019 +0530

    Update .travis.yml

    support go versions in line with go's release policy

commit e3fa7e8566f9374ac6c1e08ace0e0555f9666e10
Author: Lauris BH <lauris@nix.lv>
Date:   Wed Aug 7 11:06:15 2019 +0300

    Support also GoLang 1.11 compiler

commit b6f7dd93594d17c08d349ba5f974e501b8c12b7b
Merge: 93392d1 e2de8c7
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 13:28:34 2019 +0530

    Merge pull request #836 from urfave/flag-type-generation-golang

    Flag Generation in the CLI

commit e2de8c74587d464770155415cda09c3569224692
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Aug 7 12:38:17 2019 +0530

    update readme with correct error message, add 1.12 and 1.11 to travis

commit a77c440b8476d59b59fcf2606a92fd3bb82603c3
Merge: 8d31c5e 93392d1
Author: Robert Liebowitz <rliebz@gmail.com>
Date:   Tue Aug 6 22:33:49 2019 -0400

    Merge branch 'master' into combined

commit 24de27b05e91ef797b9ba97e3c146842fb8e29d8
Merge: c19938f 93392d1
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Wed Aug 7 01:54:44 2019 +0530

    Merge branch 'master' into flag-type-generation-golang

commit c19938fbbfb19120beeca5d0af02291a99e61f27
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Aug 7 01:51:02 2019 +0530

    update ci commands

commit 6ee5b89e03a0fc47c6351c902ef714f1475e8fde
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Aug 7 01:50:50 2019 +0530

    move build.go to root

commit e8bbb4c3b5472320f0af5fb00961c76f1061edd4
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Wed Aug 7 01:46:22 2019 +0530

    remove unnecessary sprintf

commit 5070d00811cd5f2f21b0a6e021581e8efb2479e9
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Tue Aug 6 12:33:33 2019 +0530

    move packages slice to global scope

commit 93392d12e8cd60a1c7c62dc4bf4bab7a8e001eec
Merge: 26945c5 1db0496
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Tue Aug 6 07:59:53 2019 +0100

    Merge pull request #808 from yogeshlonkar/master

    Add support for flags bash completion

commit adfe6a09c121a6b96357ea161f2d679d509c013f
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Tue Aug 6 12:14:18 2019 +0530

    indenting fix

commit 1db049685ac49e11b2e27285e1287793cfe0ea84
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Mon Aug 5 20:22:52 2019 +0200

    Fix unused regex

commit 2be2bc755e4634d34136769a426a7ca52e698cc0
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Mon Aug 5 20:18:08 2019 +0200

    Add additional test for log flag completion and comments

commit c3f51bed6fffdf84227c5b59bd3f2e90683314df
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Mon Aug 5 17:07:46 2019 +0200

    Fix SC2199: Arrays implicitly concatenate in

commit c5612e8cd21e0cd99f73d23103df99a9af70f853
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Mon Aug 5 16:58:04 2019 +0200

    Fix review comments

commit 8d31c5e167103ef4235cc5553b0fb45a2f6e8f74
Author: Robert Liebowitz <rliebz@gmail.com>
Date:   Mon Aug 5 07:05:07 2019 -0400

    Update README.md

    Co-Authored-By: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>

commit 03153b9cf8988d787fe79d02bd4138283ea507bd
Author: Robert Liebowitz <rliebz@gmail.com>
Date:   Mon Aug 5 06:16:30 2019 -0400

    Allow combining short flags globally

commit d6523cf8692d40c0ff9f6d81f7ac25341c58da7a
Merge: e949dc2 26945c5
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Mon Aug 5 11:00:26 2019 +0200

    Merge branch 'master' into master

commit 26945c58edddd8cb0830baf73ebc7bee44b5f455
Merge: d09efb5 c25e4ca
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sun Aug 4 12:36:23 2019 -0700

    Merge pull request #823 from xordspar0/master

    Make the exit code example more clear

commit c25e4cab32bab49d1d3c4847a0a6419e2cb3dd15
Merge: b1a7c50 d09efb5
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sun Aug 4 12:30:28 2019 -0700

    Merge branch 'master' into master

commit ac5c97b41844032ae47d5f94d7f73533af629f11
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:45:28 2019 +0530

    add latest assets file

commit 489d92d2e2477b240015e83af07658e826eaa7cb
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:44:15 2019 +0530

    add missing os package

commit a7f0d86509d0845980b77999dc5882b32f244818
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:33:21 2019 +0530

    add zero mod fs back and commit file with latest ts

commit 798e1f3d3aba8d04c9118962870b41ad099b7bea
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:29:53 2019 +0530

    fix spacing issue

commit 7a6f3d4394003447c99b223ce1c1e19e23b20124
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:23:32 2019 +0530

    fix tests

commit 58ae5eb590667b0115d3f82e03593d87e2924b1c
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 20:06:44 2019 +0530

    move entire build system to go

commit 8547458f1d93654348b3bbeccb6d04424d5eab3e
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 19:01:47 2019 +0530

    remove zero mod fs

commit d09efb5fbd744f23d561c02b99a16a61e679bba6
Merge: 7745000 1327f58
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sun Aug 4 18:00:11 2019 +0530

    Merge pull request #837 from urfave/codeowners

    Use codeowners instead of maintainers

commit 1327f583142a70a5d2fb9ef8422862b84a1a8780
Merge: 9938dec 7745000
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sun Aug 4 17:52:42 2019 +0530

    Merge branch 'master' into codeowners

commit e949dc2cc05a553645eea447ded78eddfec0ad37
Merge: 11c9e59 7745000
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Sun Aug 4 10:38:56 2019 +0200

    Merge branch 'master' into master

commit 4b0a4104630bddd01a7a6c5aa8a70dc94642ab52
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 12:26:48 2019 +0530

    fix travis build

commit fb4cea5f30995b6caaa700ea789902af499d63b2
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 12:22:45 2019 +0530

    add new generation logic to travis

commit 365557021fe254d059d0f7065bb0c94686208723
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 12:17:27 2019 +0530

    remove legacy version check code

commit b6bfbe97f8430a4dfe05791363719d61cb921793
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 12:16:07 2019 +0530

    update appveyor to go 1.11, add support for code coverage generation in tests

commit 826954c97919610e0f4086ab3bcc007ac3326184
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 11:09:34 2019 +0530

    update app name and remove version

commit 04948f21526ed8343ae9697600e284962d8972be
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 11:06:19 2019 +0530

    generate test with go generate

commit 86e10211dea0c2b369610aabea1c987888bbb01a
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 11:05:50 2019 +0530

    remove redundant go generate from altsrc
    update go generate in cli package to generate both files
    regeneration test

commit c676ed4caa76219414ad737584ec46b03e94cbf8
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 11:04:23 2019 +0530

    indentation fixes in template
    regeneration test

commit c4fc88e46d182072228b2b2a0236b0f77a45e567
Merge: 2a08494 9260850
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 10:29:34 2019 +0530

    Merge branch 'flag-type-generation-golang' of https://github.com/urfave/cli into flag-type-generation-golang

commit 2a084945a47235959c023291f87127ead86fc168
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 10:28:08 2019 +0530

    move around code
    change package to flag-gen to avoid conflict with flag-generator binary
    test code generation

commit 065fe9e9af992d82126929c157edb16b1a1f06ab
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 10:05:44 2019 +0530

    change structure to embed source json and template files
    restructure code to have defaults in place of choices

commit d1ded77768d33ce64657686558884e69cbb5bce4
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sun Aug 4 08:45:29 2019 +0530

    rename utility from fg > flag-generator

commit 7745000a0eabd118a94df095da6feeae887f9a34
Merge: e6cf83e 81acbeb
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sun Aug 4 08:15:00 2019 +0530

    Merge pull request #774 from whereswaldon/patch-1

    Clarify that altsrc supports both TOML and JSON

commit 81acbeb629cebde2c8c3c36421644e42ffd9e8f9
Merge: 8abc5a2 e6cf83e
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sun Aug 4 08:12:24 2019 +0530

    Merge branch 'master' into patch-1

commit e6cf83ec39f6e1158ced1927d4ed14578fda8edb
Merge: 244eba7 eee6ce8
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 3 19:37:52 2019 -0700

    Merge pull request #829 from urfave/lynncyrin-patch-2

    Release 1.21.0

commit 8abc5a2e49624c8f12a0b1734b57bd12aadf1604
Merge: b2421d1 244eba7
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sun Aug 4 08:04:13 2019 +0530

    Merge branch 'master' into patch-1

commit 9938dec695d6a0ba5a4d84b703766333cd7d10e8
Author: [[ BOT ]] Lynn Cyrin <lynncyrin@gmail.com>
Date:   Sat Aug 3 10:26:07 2019 -0700

    update contributing docs

commit 97dbddb32db290fdc6392e6a669a92acbadef9ff
Author: [[ BOT ]] Lynn Cyrin <lynncyrin@gmail.com>
Date:   Sat Aug 3 10:23:29 2019 -0700

    use codeowners instead of maintainers

commit 92608509a4c011a598dcc5b10d15930040fa403e
Merge: d209be3 244eba7
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 3 22:49:24 2019 +0530

    Merge branch 'master' into flag-type-generation-golang

commit d209be324522a802f8056094f8bb89b4562ca9a3
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sat Aug 3 22:32:36 2019 +0530

    update go generate command
    test file generation

commit add69c7d4fbef52ac8541c2f7dfa465fdd9be2c3
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sat Aug 3 22:16:25 2019 +0530

    updated flag types generated courtesy fg cli

commit c133a5aeb16e0978e3c29f8446ddf02922b7e150
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sat Aug 3 22:15:43 2019 +0530

    add explicit true/false choices for value and dest keys due to go default false for bool types

commit 16c7a60528bc5f7d98030e09630a38f3d8fc9ddc
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sat Aug 3 22:14:58 2019 +0530

    finish generation of flag types for altsrc package
    rename package to fg (flag generator)

commit 32ddef5ca7f20a9aa0e7b80484e59d1653e856e4
Author: Ajitem Sahasrabuddhe <ajitem.sahasrabuddhe@perennialsys.com>
Date:   Sat Aug 3 21:48:48 2019 +0530

    finish generation of flag types for cli package

commit 9766be8d3e11e71a2a4bb5c235fc6961278df983
Author: mingrammer <mingrammer@gmail.com>
Date:   Thu Mar 7 00:04:18 2019 +0900

    get latest changes from master

commit e01e3c540c7aea9e4e9740d002bd212491c2fe00
Author: mingrammer <mingrammer@gmail.com>
Date:   Wed Mar 6 23:51:22 2019 +0900

    Fix the unaligned indents for the commands that have no categories

commit b1a7c502eba6a479bf9432052136f73d7740a69b
Merge: c75a689 244eba7
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 3 09:36:27 2019 -0700

    Merge branch 'master' into master

commit eee6ce83c075e8aeb1d71a22f69e6fddbc70a248
Merge: 8a7f65e 244eba7
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 3 09:06:47 2019 -0700

    Merge branch 'master' into lynncyrin-patch-2

commit 11c9e598b06a0a2201f356f945c4cd2355a8ccbf
Merge: 01ab016 244eba7
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Sat Aug 3 15:52:08 2019 +0200

    Merge branch 'master' into master

commit 244eba7e4c24eb9a416bb1edadaf74d943a7bb89
Merge: 1169906 4627bbe
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 3 18:04:31 2019 +0530

    Merge pull request #831 from saschagrunert/go-modules

    Add go module support

commit b2421d123539be62bc9f2f9bdd77fce3cc2d1af6
Merge: 3e14507 1169906
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sat Aug 3 13:25:34 2019 +0100

    Merge branch 'master' into patch-1

commit 4627bbe109fb902221de0a86f20048ad5679ea0c
Author: Sascha Grunert <mail@saschagrunert.de>
Date:   Sat Aug 3 12:55:06 2019 +0200

    Add go module support

    This adds a go.{mod,sum} file to official support go modules.

    Signed-off-by: Sascha Grunert <mail@saschagrunert.de>

commit 1169906f575ec070559cc1a6fc083b38498160c0
Merge: 07c1638 94f4f83
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sat Aug 3 11:02:34 2019 +0100

    Merge pull request #773 from teresy/redundant-nil-check-slice

    Remove redundant nil checks

commit 94f4f8367278436d4554b3e7a72ec6b66c209312
Merge: da581b2 07c1638
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Sat Aug 3 02:05:33 2019 -0700

    Merge branch 'master' into redundant-nil-check-slice

commit 07c163896936a0fb3ad24dcbf05b25e9c7aaee53
Merge: 842e3fe 7a51175
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 3 08:47:32 2019 +0530

    Merge pull request #806 from mingrammer/fix-help-indentation

    Fix the unaligned indents for the command help messages

commit 7a51175ce1cb78d5009e91001697240c1af84ee2
Merge: 330a914 842e3fe
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 3 08:37:34 2019 +0530

    Merge branch 'master' into fix-help-indentation

commit 842e3fe1b6adbb257f711a1f66553ad03174c5c0
Merge: 7675649 fa51d00
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Sat Aug 3 08:12:05 2019 +0530

    Merge pull request #828 from urfave/lynncyrin-patch-1

    Update maintainers for current reality

commit 8a7f65e05215a76a2246b7b42cb9c082b5eae483
Author: Lynn Cyrin (they/them) <lynn@textio.com>
Date:   Fri Aug 2 19:30:41 2019 -0700

    Update CHANGELOG.md

commit e8eac43d9d73e96f6b034f89770ab2fdbec2cb5b
Author: Lynn Cyrin <lynn@textio.com>
Date:   Fri Aug 2 18:26:41 2019 -0700

    Update CHANGELOG.md

commit 330a9143fb1ebfe61bb382b5e45833c02a405c0c
Merge: ddc3453 7675649
Author: Lynn Cyrin <lynn@textio.com>
Date:   Fri Aug 2 18:14:50 2019 -0700

    Merge branch 'master' into fix-help-indentation

commit fa51d00dc6fb57edca14295fde308401d7720e61
Author: Lynn Cyrin <lynn@textio.com>
Date:   Fri Aug 2 18:06:15 2019 -0700

    Update maintainers for current reality

commit 01ab0164275805b0c43bc5f7f534a2d8f6abe48e
Merge: d79d2a0 7675649
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Fri Aug 2 22:03:55 2019 +0200

    Merge branch 'master' into master

commit c75a689f629137700e8a30651f95cc41cf12a6d1
Author: Jordan Christiansen <Jordan.Christiansen@target.com>
Date:   Fri Aug 2 14:28:57 2019 -0500

    Make exit code example more clear

    The purpose of this example is to show that you can exit with an error
    code if a flag is unspecified, but with the code as it is, the only way
    to cause a non-zero exit is by adding the flag `--ginger-crouton=false`,
    which is not explained in the example.

    In this new version of the example, running the command with no flag
    will exit with an error, and running it with the flag will exit
    normally.

commit 7675649a174ac724b1d7fa9d5932eff3dd1582a2
Merge: 656063a f8ba505
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 2 22:52:32 2019 +0530

    Merge pull request #819 from lynncyrin/required-flags-take-2

    Required flags

commit f8ba505a7cc01559767d9d961fb68bda833d5d3d
Merge: 60fb297 656063a
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 2 22:49:29 2019 +0530

    Merge branch 'master' into required-flags-take-2

commit 656063a84689d3e45f16ab9c40706e4df219190a
Merge: 693af58 6505336
Author: Ajitem Sahasrabuddhe <ajitem.s@outlook.com>
Date:   Fri Aug 2 22:49:09 2019 +0530

    Merge pull request #788 from benzvan/master

    adds test coverage to context

commit 60fb2972328d6a7487c6821a58a86d476167c2bd
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 23:27:34 2019 -0700

    remove help assertion stuff

commit d7ec4e801357fa5ccfab53669a42f78fc1a69d39
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 23:26:43 2019 -0700

    add env var tests

commit f4128a02f3215e532dff0b96e21a8e2cb08389a1
Author: Lynn Cyrin <lynncyrin@gmail.com>
Date:   Thu Aug 1 22:54:15 2019 -0700

    Update command.go

commit 38f9e1622d2d4a5e1a86afd8f8f9d6cbf0157816
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 22:52:21 2019 -0700

    add environment variable support :tada:

commit f21b22dd904b638518d9ea321d718f219bd6593c
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 22:10:18 2019 -0700

    cleanup some issues with error display

commit fdd4d106912b363ccffa03eec51a56dd3a6a822b
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 21:48:52 2019 -0700

    update comments

commit ef9acb4a3b846728c98844f7f92964ae2a79f259
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 21:46:56 2019 -0700

    rename cases

commit 45f2b3d8e71e11822cf591f1c370f8587726c425
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 21:45:11 2019 -0700

    more test cases

commit 78db152323afb7934f9f0dd207eeaf34147bb300
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 21:35:15 2019 -0700

    add typed error assertions

commit d4740d10d0cbde53a8e3132a0964464b2b50fc0b
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 20:58:08 2019 -0700

    more test cases

commit 595382c50970039261f765043aee4c647aeccbd5
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 20:39:37 2019 -0700

    expand test cases

commit 3d6eec825ac768894a385ca3c3156a7905c27ce3
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 20:35:23 2019 -0700

    add test cases

commit 7b9e16b6b5255803ea279fe1ee0e41973f49a42e
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 20:30:43 2019 -0700

    update test names

commit 95d3a8624d8aa6661831d0009550b602458fcb4d
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 20:27:51 2019 -0700

    update test to reflect app flag usage

commit 714a73f028fa5a3c5b6512bf5e55b94be388de8f
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 19:57:14 2019 -0700

    remove unused thing

commit 9438aba3b89e7053070ef277121a14e5fb95947e
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Aug 1 19:54:57 2019 -0700

    remove showFlagError, we can use the help printer assertion to accomplish the same goal

commit 386b379d1950e8939c8a3dbba0335cf79903f421
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sun Jul 28 22:45:43 2019 -0700

    Revert "reset generated flags changes"

    This reverts commit 9ec594d5290b846de59b0bc350849b848cabfbd7.

commit 9ec594d5290b846de59b0bc350849b848cabfbd7
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sun Jul 28 22:34:07 2019 -0700

    reset generated flags changes

commit 23f09ac1e82395dc1a70c36d649ab03929e32d79
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sun Jul 28 22:19:35 2019 -0700

    cleanup tests, check required flags in more places

commit d79d2a04242b21441061e00475287f4b826614f8
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Wed Jul 24 16:08:47 2019 +0200

    Fix issue with source command completion

    Avoid competion for bash builtin `source` and fallback to default implementation as it throws below error
    ```
    -bash: source: --: invalid option
    source: usage: source filename [arguments]
    ```

commit 7ce0af189ed431005f47e583a63648ea9a0a99ea
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:52:24 2019 -0700

    remove unused code

commit d8985dc6d56ac75b35f0422d8efbc04814bf17f3
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:51:16 2019 -0700

    reduce diff

commit 19140e1fb52f458727a3c718f82fb93861d5849c
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:48:09 2019 -0700

    show errors

commit 2299852c3c3512dafac738a10847da3bb3699b62
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:47:18 2019 -0700

    cleanup subcommand and specs

commit 300288670fe7713da8ae6e4a449d12e6c911b713
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:20:32 2019 -0700

    add subcommand

commit cc1cf8c459c947156bb429ef319f4cf762b1e468
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 18 00:09:07 2019 -0700

    wording shift

commit 32d84d8e870a7f475c228c3c58f2c879f6a4009e
Author: Lynn Cyrin <lynncyrin@gmail.com>
Date:   Wed Jul 17 00:25:13 2019 -0700

    copy update

commit 01d5cfab7066912c97eeaf94cbbda8f90fc490f7
Author: Lynn Cyrin <lynn@textio.com>
Date:   Wed Jul 17 00:20:44 2019 -0700

    use strings.Join

commit cdc7af744e07ac8dbb34793f8b392af46ba443f7
Author: Lynn Cyrin <lynn@textio.com>
Date:   Wed Jul 17 00:16:40 2019 -0700

    add handling for multiple required flags

commit 9293f5b3cc6f5a96a1976bf2f810c957044c5ee8
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sun Jul 14 21:00:16 2019 -0700

    visually shorten logic

commit f00f35ce8c1a6ebd7a3900901dd8b05049fbefc7
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 14:02:45 2019 -0700

    docs

commit 17108e1db49db34480170f575131e642b22bda2d
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 13:59:29 2019 -0700

    tabs

commit cf824804c2353572e0f99b098829f2d7ffe2a0ec
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 13:57:06 2019 -0700

    update tests

commit 80d7e91191cfb38c7e3fccbcf2b1320807d4b05d
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 03:51:26 2019 -0700

    fill out test cases

commit 746866c10daf9425d41140f78ffc518ee4d9ae01
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 03:44:39 2019 -0700

    add update integration with the help output

commit 550ed20ea429e19b7b132984a6e34c057acabc42
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 01:26:47 2019 -0700

    update tests

commit f6777bf4bf44867abbcaa63a97a67db60469ea80
Author: Lynn Cyrin <lynn@textio.com>
Date:   Sat Jul 13 01:03:46 2019 -0700

    quote the flag name

commit 6a2ae783730e54eb7ea91cf6839ed46446134017
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 21:53:10 2019 -0700

    backwards compatible RequiredFlag implementation

commit 922d2318916c3b59eafde03c36b12551a71f2d51
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 21:28:09 2019 -0700

    ./generate-flag-types cli -i flag-types.json -o flag_generated.go

commit 8a58b7e039e37b0631d6ced0ab3279c319c4d8c8
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:47:47 2019 -0700

    remove manual isRequired funcs

commit 62e99ad1c16714cda6c9f8b980dd9483372771e2
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:46:22 2019 -0700

    add IsRequired to generator

commit 310bfeb1942571dfe0ac9f60f45e75df11189e4e
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:44:41 2019 -0700

    add required attr to generator

commit af627c73c3ddc2d4ff1e4c0847c3355bc0a47c0d
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:34:17 2019 -0700

    update func name

commit 3d2d6975b4fffee753c9422f3440d6b7c114ef40
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:32:42 2019 -0700

    reduce diff

commit 0608059cc709e86905bfd18886d6649275c9937e
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:32:15 2019 -0700

    reduce diff

commit 9c299e7e8af265e017adf7abf431a0fe0c89dd95
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:28:29 2019 -0700

    reduce diff

commit 30a71dc427bc2634f00d9fe315e5717022e0eb66
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:25:52 2019 -0700

    update Run command

commit f7d5e2c21e4cca02de26a7f448d69f4dac531af7
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:22:16 2019 -0700

    reduce diff

commit e6842c0b7521b5e608da30a4e8a5ed06e6469cf7
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:21:05 2019 -0700

    merge in test file

commit fa8187f2ce6a7d8258899b46ccfe081c9c0ea6f7
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:19:42 2019 -0700

    reduce diff

commit ce1630141e70b2ca599a21fd9494e98b88f25b2d
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:18:52 2019 -0700

    reduce diff???

commit 138dbaafec9db29d5b0b10af383ca7c6848a2c0d
Merge: aba73ce 693af58
Author: Lynn Cyrin <lynn@textio.com>
Date:   Thu Jul 11 20:07:55 2019 -0700

    Merge branch 'master' into required_flags

commit da581b24e88a3b8d5b3d4b7685f9eee32ec0df8e
Merge: 6aa7f35 693af58
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Fri Jun 28 07:55:04 2019 +0100

    Merge branch 'master' into redundant-nil-check-slice

commit 65053360c7533fc585bdb9f53abada1e9b39f564
Author: Ben Zvan <ben.zvan@target.com>
Date:   Wed Jun 26 09:41:11 2019 -0500

    Revert "Created using Colaboratory"

    This reverts commit 83b99c4109dce6ac7a6b5d2048e26f1ad60ef3f3.
    This commit was randomly created here when I connected to colaboratory

commit 83b99c4109dce6ac7a6b5d2048e26f1ad60ef3f3
Author: Ben Zvan <ben@zvan.net>
Date:   Tue Jun 25 18:47:58 2019 -0500

    Created using Colaboratory

commit 23042d37079702af32e4bcae8d41bb72569431da
Merge: 4a76377 693af58
Author: Ben Zvan <ben@zvan.net>
Date:   Fri Jun 14 10:14:07 2019 -0500

    Merge branch 'master' into master

commit 62f02f21ef0b5c3c0aa67d3240aee15bc8a53457
Author: Yogesh Lonkar <ylonkar@whitehedge.com>
Date:   Thu Apr 11 10:57:58 2019 +0530

    Don't complete hidden flags

commit 1d7a2b08d6f8e9764e2f2b911b1bb9fa49596f92
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Thu Mar 21 13:01:48 2019 +0530

    Add default completion on commands, test cases, refactor code

commit fb1421d9031313c5e0f3c4a92625ed9cf5739b0d
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Wed Mar 20 21:34:56 2019 +0530

    Fix duplicate completion of existing flag

commit 58a072d5733d4bb2dc61ffbc3557ec9592e34adc
Author: Yogesh Lonkar <lonkar.yogeshr@gmail.com>
Date:   Wed Mar 20 20:28:51 2019 +0530

    Add bash completion support for flags

commit ddc3453179ea450663473db4689f7c256225a72b
Author: mingrammer <mingrammer@gmail.com>
Date:   Thu Mar 7 00:04:18 2019 +0900

    Update README.md

commit a0453b2200cafa97ce263a4a5df87f5087d2abda
Author: mingrammer <mingrammer@gmail.com>
Date:   Wed Mar 6 23:51:22 2019 +0900

    Fix the unaligned indents for the commands that have no categories

commit 693af58b4d51b8fcc7f9d89576da170765980581
Merge: e229212 d7c3be8
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sun Feb 3 18:40:40 2019 +0000

    Merge pull request #766 from agis/patch-1

    Fix README typo

commit 6aa7f352fa56438b4c8fcaff43e1050855526051
Merge: 21dfc6e e229212
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sun Feb 3 18:39:49 2019 +0000

    Merge branch 'master' into redundant-nil-check-slice

commit e2292127695d01e9fc3511f2ec7ef651bf3ca8af
Merge: b67dcf9 5b83c89
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Sun Feb 3 18:37:18 2019 +0000

    Merge pull request #798 from Quasilyte/patch-1

    use type switch instead of if/else

commit 5b83c895a70b7714548f0aa4f43deb3fa5fc1601
Author: Iskander (Alex) Sharipov <quasilyte@gmail.com>
Date:   Tue Jan 29 22:51:02 2019 +0300

    use type switch instead of if/else

    This reduces the syntax noise of the code by
    removing excessive type assertions.

    Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>

commit 4a76377775cebfc3dca4af752ba2837f9694b9d8
Author: Ben Zvan <benjamin.zvan@target.com>
Date:   Wed Dec 26 12:48:12 2018 -0600

    go fmt

commit d63733fe14aad10beca5490a453904bc1d67fe16
Author: Ben Zvan <benjamin.zvan@target.com>
Date:   Wed Dec 26 12:41:27 2018 -0600

    adds test coverage to context

commit b67dcf995b6a7b7f14fad5fcb7cc5441b05e814b
Merge: cbebba9 11ab68f
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Mon Oct 29 21:32:00 2018 +0000

    Merge pull request #776 from gliptak/patch-2

    Bring Go version current

commit 11ab68f24d392fc36615c650bc6241c0b96c4318
Merge: 769f6d5 cbebba9
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Mon Oct 29 21:19:45 2018 +0000

    Merge branch 'master' into patch-2

commit cbebba941b23ee6f666b057c9f3d0937263ddd01
Merge: 934abfb 9587fc2
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Mon Oct 29 21:18:40 2018 +0000

    Merge pull request #775 from gliptak/patch-1

    Correct typo

commit 769f6d543bd3c9b36b98e3a46ad646cf63769120
Author: Gábor Lipták <gliptak@gmail.com>
Date:   Thu Oct 18 21:00:02 2018 -0400

    Bring Go version current

commit 9587fc27bd923141975eac8c34288bcf8de5cca2
Author: Gábor Lipták <gliptak@gmail.com>
Date:   Thu Oct 18 20:56:13 2018 -0400

    Correct typo

commit 3e145076abdbaf5c6e47e311b5e659251604a49b
Author: Christopher Waldon <christopher.waldon.dev@gmail.com>
Date:   Fri Oct 12 11:30:46 2018 -0400

    Clarify that altsrc supports both TOML and JSON

commit 21dfc6eb8302c4db3547a22b0843c43e36fe058e
Author: teresy <hi.teresy@gmail.com>
Date:   Wed Oct 10 14:54:48 2018 -0400

    Remove redundant nil checks

commit d7c3be82673f869fed4ea77a0c5e3f13bd65ba89
Author: Agis Anastasopoulos <827224+agis@users.noreply.github.com>
Date:   Tue Aug 21 11:19:37 2018 +0300

    Fix README typo

commit 934abfb2f102315b5794e15ebc7949e4ca253920
Merge: 8e01ec4 3e5a935
Author: Audrius Butkevicius <audrius.butkevicius@gmail.com>
Date:   Tue Aug 21 07:40:27 2018 +0100

    Merge pull request #758 from vrothberg/fix-short-opts-parsing

    short opt handling: fix parsing

commit 3e5a935ed3cafadcddc6f5ab2fe7ddd2aa0c3cea
Author: Valentin Rothberg <vrothberg@suse.com>
Date:   Tue Aug 21 08:33:42 2018 +0200

    fix `go vet` warning

    command_test.go:342:3 value declared but not used

    Signed-off-by: Valentin Rothberg <vrothberg@suse.com>

commit c23dfba7018a4666892af705d89150a5f1ac8293
Author: Valentin Rothberg <vrothberg@suse.com>
Date:   Thu Jun 28 16:41:02 2018 +0200

    short opt handling: fix parsing

    Only split a given string (e.g., "-abc") into short options (e.g., "-a",
    "-b", "-c") if all those are flags.  To further avoid mistakenly
    transform common arguments, catch "flag provided but not defined" errors
    to iteratively transform short options.

    Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
    Fixes: https://github.com/projectatomic/libpod/issues/714

commit 8e01ec4cd3e2d84ab2fe90d8210528ffbb06d8ff
Merge: d4bf9ce 8dc47eb
Author: Dan Buch <dan@meatballhat.com>
Date:   Sun Feb 25 22:02:53 2018 -0500

    Merge pull request #598 from urfave/backport-json-support

    Backport JSON InputSource to v1

commit 8dc47eb3cbaea99e0d3e04424f6f3649657a6944
Merge: f551359 d4bf9ce
Author: Dan Buch <dan@meatballhat.com>
Date:   Sun Feb 25 16:09:48 2018 -0500

    Merge branch 'master' into backport-json-support

commit d4bf9ce8609adfc60775b62676fa3471e7d978e0
Merge: b09aafd e59e474
Author: Dan Buch <dan@meatballhat.com>
Date:   Sun Feb 25 16:09:04 2018 -0500

    Merge pull request #498 from urfave/merging-jereksel-zsh

    Merging #489 (plus hack)

commit e59e4743b884a22e06b1b78a893c68513c0702b7
Merge: 5fc8124 b09aafd
Author: Dan Buch <dan@meatballhat.com>
Date:   Sat Feb 24 22:02:40 2018 -0500

    Merge branch 'master' into merging-jereksel-zsh

commit b09aafdfe9ad3fa4353b82eaed4e80598878c128
Merge: 446f49e bc77a15
Author: Dan Buch <dan@meatballhat.com>
Date:   Sat Feb 24 22:02:19 2018 -0500

    Merge pull request #681 from urfave/check-run-error-in-readme

    Update README examples to check for errors

commit 5fc8124af17aae44085140a2a7b3141a973dbda0
Merge: 688c5a9 446f49e
Author: Dan Buch <dan@meatballhat.com>
Date:   Sat Feb 24 21:58:26 2018 -0500

    Merge branch 'master' into merging-jereksel-zsh

commit bc77a15c69f9aadd39b15be9373abc4916c8ad53
Merge: 59e1ddb 446f49e
Author: Dan Buch <dan@meatballhat.com>
Date:   Sat Feb 24 21:54:06 2018 -0500

    Merge branch 'master' into check-run-error-in-readme

commit 446f49e78f79a164079a99a88446182703331c75
Merge: a1c7408 45289ea
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Tue Feb 20 21:16:31 2018 -0800

    Merge pull request #715 from urfave/maintainers-notice

    Adjust contribution and maintainer prose per current reality

commit 45289ea7a0de564a71532e13b9916961a38abc8e
Author: Dan Buch <dan@meatballhat.com>
Date:   Tue Feb 20 12:40:43 2018 -0500

    Adjust contribution and maintainer prose per current reality

commit 59e1ddb43ed48e52bf1a0aca8a310d9bca9897d7
Merge: 9838c8b a1c7408
Author: Dan Buch <dan@meatballhat.com>
Date:   Tue Feb 13 15:27:04 2018 -0500

    Merge branch 'master' into check-run-error-in-readme

commit a1c7408de3f632d86eee604a3bb755f1ffb68226
Merge: 803d066 3a87b13
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sat Feb 10 18:18:39 2018 -0800

    Merge pull request #712 from windler/fix_args_reorder

    Fix args reordering when bool flags are present

commit 3a87b13b01ac8628694f1e1b20bdb452cc0f54d2
Author: Nico Windler <nico.windler@gmail.com>
Date:   Sat Feb 10 13:35:23 2018 +0100

    Fix args reordering when bool flags are present

commit 803d0665796d3b09d3190067803fc285d1604732
Merge: 75104e9 d7555e1
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Fri Feb 2 13:13:18 2018 -0800

    Merge pull request #704 from dolmen/replace-unneeded-Sprintf

    Fix unnecessary uses of Sprintf

commit d7555e172994da8d058334aa1fe69533b1685924
Author: Olivier Mengué <dolmen@cpan.org>
Date:   Fri Jan 26 21:14:34 2018 +0100

    Fix unnecessary uses of Sprintf

    - use strconv directly
    - use concatenation for "%s%s"

commit 75104e932ac2ddb944a6ea19d9f9f26316ff1145
Merge: 39908eb e38e4ae
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sat Jan 6 11:10:48 2018 -0800

    Merge pull request #697 from urfave/fix-skip-flag-parsing

    Fix regression of SkipFlagParsing behavior

commit e38e4ae2d05acf5b5164c160a67fb7048e1358b0
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Fri Dec 29 13:38:18 2017 -0500

    Fix regression of SkipFlagParsing behavior

    Introduced by df562bf1a8626f2d16f91fcbf7230a5bdca3d592

    Was mistakenly prepending the command name.

commit 39908eb08fee7c10d842622a114a5c133fb0a3c6
Merge: 119bb65 2610681
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Tue Dec 12 08:34:29 2017 -0800

    Merge pull request #691 from urfave/refactor-686

    Refactor flag handling logic

commit 2610681040722bb0a9d04c3a784a44d2efb52379
Merge: 0671b16 119bb65
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Mon Dec 11 18:51:46 2017 -0800

    Merge branch 'master' into refactor-686

commit 0671b166dcacb3dc1215ba65bf986dab194581dc
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Mon Dec 4 09:23:40 2017 -0800

    Add tests for flag reordering

commit 119bb6564841921ce6f1401e0f5d75317bdd9f4d
Merge: c9eba3f c6eb2a0
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sun Dec 3 13:42:37 2017 -0800

    Merge pull request #690 from gliptak/patch-1

    Correct go vet for Go tip

commit df562bf1a8626f2d16f91fcbf7230a5bdca3d592
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sun Dec 3 13:38:50 2017 -0800

    Refactor flag handling logic

    Refactor logic introduced by #686

commit c9eba3f37a524c4fed60a8f3585ea5f304fd436d
Merge: c6af884 ceaac7c
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sun Dec 3 12:48:28 2017 -0800

    Merge pull request #686 from baude/shortoptionSkipArg

    Handle ShortOptions and SkipArgReorder

commit c6eb2a051026c083d4e33591f8d6e95d5f4189dc
Author: Gábor Lipták <gliptak@gmail.com>
Date:   Thu Nov 30 19:43:12 2017 -0500

    Correct go vet for Go tip

    https://travis-ci.org/cloudflare/logshare/jobs/309796141#L646

commit ceaac7c9152121e6ba0f3b492b3254d61346f92a
Author: baude <bbaude@redhat.com>
Date:   Mon Nov 20 09:32:03 2017 -0600

    Handle ShortOptions and SkipArgReorder

    There was a bug in parsing when both ShortOptions
    and SkipArgReorder were being used together.

    Signed-off-by: baude <bbaude@redhat.com>

commit c6af8847eb2b7b297d07c3ede98903e95e680ef9
Merge: 7ace96b 37b7abb
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Mon Nov 27 19:55:04 2017 -0800

    Merge pull request #687 from joshuarubin/master

    Don't clobber slices with EnvVar

commit 37b7abb1c491c8c3630a2a98bb02a7051efbcc06
Author: Joshua Rubin <jrubin@zvelo.com>
Date:   Tue Nov 21 15:21:31 2017 -0700

    dont clobber slices with envvar

    Signed-off-by: Joshua Rubin <jrubin@zvelo.com>

commit 7ace96b43d4bdc46f81d0d1219742b2469874cf6
Merge: 44cb242 fd5382e
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Wed Nov 15 20:56:12 2017 -0800

    Merge pull request #684 from baude/shortOptionHandling

    Combine bool short names

commit fd5382e7a539858cc19d7eed7755f7102bae5da9
Author: baude <bbaude@redhat.com>
Date:   Mon Nov 13 15:28:23 2017 -0600

    Combine bool short names

    Adds the ability to allow the combination of bool
    short-name options.  For example,

    cmd foobar -ov

    This is done through a bool "UseShortOptionHandler" set in
    the command struct.

    Built upon PR #621

    Signed-off-by: baude <bbaude@redhat.com>

commit 9838c8bcaa19fdb33259f6e0f9740d9fd3cbe13c
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sat Nov 11 16:23:24 2017 -0800

    Update README examples to check for errors

    To encourage good practices.

commit 43c8c02cf5a10196e5a4c458fdbfee90a561e97c
Author: zhuchensong <zhuchensong93@163.com>
Date:   Mon Apr 17 00:47:04 2017 +0800

    Support POSIX-style short flag combining

commit 44cb242eeb4d76cc813fdc69ba5c4b224677e799
Merge: 7f4b273 f971fca
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Fri Nov 3 19:35:40 2017 -0700

    Merge pull request #675 from jmccann/continue3

    Ability to load variable from file - UPDATED

commit f971fca2b2664c4dec0cee24225dc3c415211498
Author: Jacob McCann <jacob.mccann2@target.com>
Date:   Thu Oct 26 13:08:03 2017 -0500

    Allow FilePath to take []string

commit 18a556e1927fbe11c31fae47a7e3acf275ef6ae4
Author: Brad Rydzewski <brad.rydzewski@gmail.com>
Date:   Mon Apr 10 16:45:51 2017 +0200

    fix FilePath documentation in README.md

commit 4cc453ba6792515a8013340f8919e6c4b44851b7
Author: Brad Rydzewski <brad.rydzewski@gmail.com>
Date:   Sat Apr 1 12:55:46 2017 +0900

    document field in README

commit c698b821b896e9723d53c4ad1e81680f39a8cdc1
Author: Brad Rydzewski <brad.rydzewski@gmail.com>
Date:   Sat Apr 1 12:37:06 2017 +0900

    unit tests for load from file

commit 21fcab0dee7dab6969e929cf1740306bae1e16ad
Author: Brad Rydzewski <brad.rydzewski@gmail.com>
Date:   Fri Mar 31 16:24:15 2017 +0900

    ability to load variable from file

commit 7f4b273a05858e05b96b6adf0a7907b7b695c352
Merge: 7bc6a0a b44660a
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Mon Oct 30 19:55:34 2017 -0700

    Merge pull request #676 from rliebz/lexicographic-sort

    Consider case when sorting strings

commit b44660ac3da2f8e651372c40ae803782bddea283
Author: Robert Liebowitz <rliebz@gmail.com>
Date:   Sat Oct 28 03:00:11 2017 -0400

    Consider case when sorting strings

    This makes sorting flags and other sections consistent with how most
    command line tools function, by placing both flags `-A` and `-a` before
    a flag `-B`.

commit 7bc6a0acffa589f415f88aca16cc1de5ffd66f9c
Merge: 2997500 40263f4
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sat Oct 14 13:27:26 2017 -0700

    Merge pull request #628 from phinnaeus/master

    Allow custom ExitError handler function

commit 40263f4d6aaf7383fb53bd97a5c34c02be39eda8
Merge: 7233c50 2997500
Author: Tyler Davis <phinnaeus@users.noreply.github.com>
Date:   Fri Oct 13 12:05:14 2017 -0700

    Merge branch 'master' into master

commit 2997500ba5f393daa5d76c18544c6367b2c48d16
Merge: ac24947 c202606
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Sat Oct 7 13:56:23 2017 -0700

    Merge pull request #672 from sierraechobravo/master

    fix go report card issues

commit c202606a17a763fcc1b320cac6cf584662e31364
Author: Sebastian Sprenger <Sebastian.Sprenger@booxware.de>
Date:   Fri Oct 6 07:29:13 2017 +0200

    fix golint issues

commit c3cc74dac756e33c2919ab998481809e8720e068
Author: Sebastian Sprenger <Sebastian.Sprenger@booxware.de>
Date:   Fri Oct 6 07:28:43 2017 +0200

    fix ineffective assigns

commit 67ee172e6da2cdad8e48af107eef0fbfd1e85eec
Author: Sebastian Sprenger <Sebastian.Sprenger@booxware.de>
Date:   Fri Oct 6 07:28:18 2017 +0200

    fix misspelling issue

commit ac249472b7de27a9e8990819566d9be95ab5b816
Merge: 7fb9c86 cbbe4c1
Author: Jesse Szwedko <jesse.szwedko@gmail.com>
Date:   Mon Sep 25 20:41:18 2017 -0700

    Merge pull request #661 from rliebz/custom-flag-help

    Allow customization of prefixes and environment variable hints in flag help strings

commit 7233c502e31b3e6d93e3e8cf5fe0616f4d32c020
Merge: 5dc55f2 7fb9c86
Author: Tyler Davis <phinnaeus@users.noreply.github.com>
Date:   Fri Sep 22 10:08:36 2017 -0700

    Merge branch 'master' into master

commit cbbe4c1a2c34e52c8ad0937c01c9c15ef407a6d5
Author: Robert Liebowitz <rliebz@gmail.com>
Date:   Mon Sep 18 00:44:42 2017 -0400

    Add tests for custom flag prefix/env hints

commit 11d45572f9727acfbc93daa8565f379d396125d6
Author: rliebz <rliebz@gmail.com>
Date:   Sat Aug 26 07:42:25 2017 -0400

    Export funcs to configure flag prefix/env hints

    This will allow users to customize the prefix section or env hint
    section of the flag entries in the help menu without having to
    reimplement the rest of the logic required in defining FlagStringer.

commi…
  • Loading branch information
asahasrabuddhe committed Sep 16, 2019
1 parent ef1ba86 commit b161244b73fe20b8a0728bbd2637f6e6dfa63f2f
Showing with 32 additions and 197 deletions.
  1. +3 −3 CHANGELOG.md
  2. +6 −10 README.md
  3. +4 −3 altsrc/json_source_context.go
  4. +1 −1 altsrc/toml_command_test.go
  5. +8 −35 app.go
  6. +0 −74 app_test.go
  7. +0 −1 appveyor.yml
  8. +0 −4 command.go
  9. +1 −1 command_test.go
  10. +1 −53 context.go
  11. +1 −3 context_test.go
  12. +1 −2 flag.go
  13. +0 −1 flag_int64.go
  14. +1 −0 flag_int_slice.go
  15. +0 −1 flag_string_slice.go
  16. +0 −2 flag_test.go
  17. +1 −0 help.go
  18. +4 −3 template.go
@@ -20,10 +20,10 @@
To migrate to the new API, you may choose to run [the migrator
(python) script](./cli-v1-to-v2).
- The optimistic reordering of arguments and flags introduced by
https://github.com/codegangsta/cli/pull/36. This behavior only worked when
https://github.com/urfave/cli/pull/36. This behavior only worked when
all arguments appeared before all flags, but caused [weird issues with boolean
flags](https://github.com/codegangsta/cli/issues/103) and [reordering of the
arguments](https://github.com/codegangsta/cli/issues/355) when the user
flags](https://github.com/urfave/cli/issues/103) and [reordering of the
arguments](https://github.com/urfave/cli/issues/355) when the user
attempted to mix flags and arguments. Given the trade-offs we removed support
for this reordering.
- adapter code for deprecated `Action` func signature
@@ -19,7 +19,7 @@ applications in an expressive way.
- [Installation](#installation)
* [Supported platforms](#supported-platforms)
* [Using the `v2` branch](#using-the-v2-branch)
* [Pinning to the `v1` releases](#pinning-to-the-v1-releases)
* [Using `v1` releases](#using-v1-releases)
- [Getting Started](#getting-started)
- [Examples](#examples)
* [Arguments](#arguments)
@@ -104,9 +104,6 @@ import (
...
```

**NOTE**: There is a [migrator (python) script](./cli-v1-to-v2) available to aid
with the transition from the v1 to v2 API.

### Pinning to the `v1` releases

Similarly to the section above describing use of the `v2` branch, if one wants
@@ -120,7 +117,7 @@ $ go get github.com/urfave/cli
```go
...
import (
"github.com/urfave/cli/v2"
"github.com/urfave/cli"
)
...
```
@@ -710,11 +707,10 @@ Here is a more complete sample of a command using YAML support:
"output": "&#45&#45;test value.*default: 0"
} -->
``` go
package notmain
package main
import (
"fmt"
"log"
"os"
"github.com/urfave/cli/v2"
@@ -735,7 +731,7 @@ func main() {
Before: altsrc.InitInputSourceWithContext(flags, altsrc.NewYamlSourceFromFlagFunc("load")),
Flags: flags,
}
app.Run(os.Args)
}
```
@@ -949,7 +945,7 @@ func main() {
},
Action: func(ctx *cli.Context) error {
if !ctx.Bool("ginger-crouton") {
return cli.Exit(Ginger croutons are not in the soup, 86)
return cli.Exit("Ginger croutons are not in the soup", 86)
}
return nil
},
@@ -986,7 +982,7 @@ import (
"fmt"
"log"
"os"
"github.com/urfave/cli/v2"
)
@@ -66,10 +66,10 @@ func (x *jsonSource) Int(name string) (int, error) {
return 0, fmt.Errorf("unexpected type %T for %q", i, name)
case int:
return v, nil
case float64:
return int(v), nil
case float32:
return int(v), nil
case float64:
return int(v), nil
}
}

@@ -203,5 +203,6 @@ func jsonGetValue(key string, m map[string]interface{}) (interface{}, error) {

type jsonSource struct {
file string
deserialized map[string]interface{}
deserialized map[string]interface {
}
}
@@ -241,7 +241,7 @@ func TestCommandTomlFileTestDefaultValueFileWinsNested(t *testing.T) {
}

func TestCommandTomlFileFlagHasDefaultGlobalEnvTomlSetGlobalEnvWins(t *testing.T) {
app := (&cli.App{})
app := &cli.App{}
set := flag.NewFlagSet("test", 0)
_ = ioutil.WriteFile("current.toml", []byte("test = 15"), 0666)
defer os.Remove("current.toml")
43 app.go
@@ -11,16 +11,14 @@ import (
"time"
)

var (
changeLogURL = "https://github.com/urfave/cli/blob/master/CHANGELOG.md"
appActionDeprecationURL = fmt.Sprintf("%s#deprecated-cli-app-action-signature", changeLogURL)

contactSysadmin = "This is an error in the application. Please contact the distributor of this application if this is not you."

errInvalidActionType = NewExitError("ERROR invalid Action type. "+
fmt.Sprintf("Must be `func(*Context`)` or `func(*Context) error). %s", contactSysadmin)+
fmt.Sprintf("See %s", appActionDeprecationURL), 2)
)
//var (
// changeLogURL = "https://github.com/urfave/cli/blob/master/CHANGELOG.md"
// appActionDeprecationURL = fmt.Sprintf("%s#deprecated-cli-app-action-signature", changeLogURL)
// contactSysadmin = "This is an error in the application. Please contact the distributor of this application if this is not you."
// errInvalidActionType = NewExitError("ERROR invalid Action type. "+
// fmt.Sprintf("Must be `func(*Context`)` or `func(*Context) error). %s", contactSysadmin)+
// fmt.Sprintf("See %s", appActionDeprecationURL), 2)
//)

// App is the main structure of a cli application. It is recommended that
// an app be created with the cli.NewApp() function
@@ -534,28 +532,3 @@ func (a *Author) String() string {

return fmt.Sprintf("%v%v", a.Name, e)
}

// DefaultAppComplete returns an ActionFunc to run a default command if non were passed.
// Usage: `app.Action = cli.DefaultCommand("command")`
func DefaultCommand(name string) ActionFunc {
return func(ctx *Context) error {
return ctx.App.Command(name).Run(ctx)
}
}

// HandleAction attempts to figure out which Action signature was used. If
// it's an ActionFunc or a func with the legacy signature for Action, the func
// is run!
func HandleAction(action interface{}, context *Context) (err error) {
switch a := action.(type) {
case ActionFunc:
return a(context)
case func(*Context) error:
return a(context)
case func(*Context): // deprecated function signature
a(context)
return nil
}

return errInvalidActionType
}
@@ -445,63 +445,6 @@ func TestApp_Setup_defaultsWriter(t *testing.T) {
expect(t, app.Writer, os.Stdout)
}


//func TestApp_CommandWithArgBeforeFlags(t *testing.T) {
// var parsedOption, firstArg string
//
// app := NewApp()
// command := &Command{
// Name: "cmd",
// Flags: []Flag{
// &StringFlag{Name: "option", Value: "", Usage: "some option"},
// },
// Action: func(c *Context) error {
// parsedOption = c.String("option")
// firstArg = c.Args().First()
// return nil
// },
// }
// app.Commands = []*Command{command}
//
// _ = app.Run([]string{"", "cmd", "my-arg", "--option", "my-option"})
//
// expect(t, parsedOption, "my-option")
// expect(t, firstArg, "my-arg")
//}
//
//func TestApp_CommandWithArgBeforeBoolFlags(t *testing.T) {
// var parsedOption, parsedSecondOption, firstArg string
// var parsedBool, parsedSecondBool bool
//
// app := NewApp()
// command := &Command{
// Name: "cmd",
// Flags: []Flag{
// &StringFlag{Name: "option", Value: "", Usage: "some option"},
// &StringFlag{Name: "secondOption", Value: "", Usage: "another option"},
// &BoolFlag{Name: "boolflag", Usage: "some bool"},
// &BoolFlag{Name: "b", Usage: "another bool"},
// },
// Action: func(c *Context) error {
// parsedOption = c.String("option")
// parsedSecondOption = c.String("secondOption")
// parsedBool = c.Bool("boolflag")
// parsedSecondBool = c.Bool("b")
// firstArg = c.Args().First()
// return nil
// },
// }
// app.Commands = []*Command{command}
//
// _ = app.Run([]string{"", "cmd", "my-arg", "--boolflag", "--option", "my-option", "-b", "--secondOption", "fancy-option"})
//
// expect(t, parsedOption, "my-option")
// expect(t, parsedSecondOption, "fancy-option")
// expect(t, parsedBool, true)
// expect(t, parsedSecondBool, true)
// expect(t, firstArg, "my-arg")
//}

func TestApp_RunAsSubcommandParseFlags(t *testing.T) {
var context *Context

@@ -2073,23 +2016,6 @@ func TestHandleExitCoder_Custom(t *testing.T) {
}
}

func TestHandleAction_WithUnknownPanic(t *testing.T) {
defer func() { refute(t, recover(), nil) }()

var fn ActionFunc

app := NewApp()
app.Action = func(ctx *Context) error {
_ = fn(ctx)
return nil
}
fs, err := flagSet(app.Name, app.Flags)
if err != nil {
t.Errorf("error creating FlagSet: %s", err)
}
_ = HandleAction(app.Action, NewContext(app, fs, nil))
}

func TestShellCompletionForIncompleteFlags(t *testing.T) {
app := &App{
Flags: []Flag{
@@ -26,4 +26,3 @@ build_script:
- go run build.go vet
- go run build.go test
- go run build.go gfmrun

@@ -184,10 +184,6 @@ func (c *Command) parseFlags(args Args) (*flag.FlagSet, error) {
return set, set.Parse(append([]string{"--"}, args.Tail()...))
}

//if !c.SkipArgReorder {
// args = reorderArgs(args)
//}

set, err := parseIter(c, args.Tail())
if err != nil {
return nil, err
@@ -28,7 +28,7 @@ func TestCommandFlagParsing(t *testing.T) {
for _, c := range cases {
app := &App{Writer: ioutil.Discard}
set := flag.NewFlagSet("test", 0)
set.Parse(c.testArgs)
_ = set.Parse(c.testArgs)

context := NewContext(app, set, nil)

@@ -74,40 +74,11 @@ func (c *Context) IsSet(name string) bool {
}
}

// XXX hack to support IsSet for flags with EnvVar
//
// There isn't an easy way to do this with the current implementation since
// whether a flag was set via an environment variable is very difficult to
// determine here. Instead, we intend to introduce a backwards incompatible
// change in version 2 to add `IsSet` to the Flag interface to push the
// responsibility closer to where the information required to determine
// whether a flag is set by non-standard means such as environment
// variables is available.
//
// See https://github.com/urfave/cli/issues/294 for additional discussion
f := lookupFlag(name, c)
if f == nil {
return false
}

//val := reflect.ValueOf(f)
//if val.Kind() == reflect.Ptr {
// val = val.Elem()
//}
//
//filePathValue := val.FieldByName("FilePath")
//if !filePathValue.IsValid() {
// return false
//}
//
//envVarValues := val.FieldByName("EnvVars")
//if !envVarValues.IsValid() {
// return false
//}
//
//_, ok := flagFromEnvOrFile(envVarValues.Interface().([]string), filePathValue.Interface().(string))
//return ok

return f.IsSet()
}

@@ -132,30 +103,6 @@ func (c *Context) FlagNames() []string {
return names
}

// FlagNames returns a slice of flag names used in this context.
//func (c *Context) FlagNames() (names []string) {
// for _, f := range c.Command.Flags {
// name := strings.Split(f.GetName(), ",")[0]
// if name == "help" {
// continue
// }
// names = append(names, name)
// }
// return
//}

// GlobalFlagNames returns a slice of global flag names used by the app.
//func (c *Context) GlobalFlagNames() (names []string) {
// for _, f := range c.App.Flags {
// name := strings.Split(f.GetName(), ",")[0]
// if name == "help" || name == "version" {
// continue
// }
// names = append(names, name)
// }
// return names
//}

// Lineage returns *this* context and all of its ancestor contexts in order from
// child to parent
func (c *Context) Lineage() []*Context {
@@ -310,6 +257,7 @@ func checkRequiredFlags(flags []Flag, context *Context) requiredFlagsErr {
if rf, ok := f.(RequiredFlag); ok && rf.IsRequired() {
var flagPresent bool
var flagName string

for _, key := range f.Names() {
if len(key) > 1 {
flagName = key
@@ -3,12 +3,9 @@ package cli
import (
"context"
"flag"

"sort"

"os"
"strings"

"testing"
"time"
)
@@ -462,6 +459,7 @@ func TestCheckRequiredFlags(t *testing.T) {
parseInput: []string{"-n", "asd", "-n", "qwe"},
},
}

for _, test := range tdata {
t.Run(test.testCase, func(t *testing.T) {
// setup
@@ -314,7 +314,7 @@ func stringifyIntSliceFlag(f *IntSliceFlag) string {
var defaultVals []string
if f.Value != nil && len(f.Value.Value()) > 0 {
for _, i := range f.Value.Value() {
defaultVals = append(defaultVals, fmt.Sprintf("%d", i))
defaultVals = append(defaultVals, strconv.Itoa(i))
}
}

@@ -346,7 +346,6 @@ func stringifyFloat64SliceFlag(f *Float64SliceFlag) string {

func stringifyStringSliceFlag(f *StringSliceFlag) string {
var defaultVals []string

if f.Value != nil && len(f.Value.Value()) > 0 {
for _, s := range f.Value.Value() {
if len(s) > 0 {

0 comments on commit b161244

Please sign in to comment.
You can’t perform that action at this time.