Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required flags documentation #1008

Merged
merged 18 commits into from
Dec 25, 2019
Merged

Add required flags documentation #1008

merged 18 commits into from
Dec 25, 2019

Conversation

coilysiren
Copy link
Member

@coilysiren coilysiren commented Dec 21, 2019

Motivation

Fixes #961

Changes

Adds documentation for required flags

Testing

I had a little back and forth with gfmrun while working on this 😄

Additional Context

I merged #886 via @anberns into this PR, since I copy pasted some of the example from them ^^

@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #1008 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1008   +/-   ##
======================================
  Coverage    72.5%   72.5%           
======================================
  Files          33      33           
  Lines        2495    2495           
======================================
  Hits         1809    1809           
  Misses        575     575           
  Partials      111     111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1b271...78a8ee9. Read the comment docs.

…e' into lynncyrin-patch-8

Co-authored-by: Aaron Berns <anberns@gmail.com>
@coilysiren coilysiren self-assigned this Dec 21, 2019
@coilysiren coilysiren changed the title 🚧 required flags documentation 🚧 Add required flags documentation Dec 21, 2019
@coilysiren coilysiren marked this pull request as ready for review December 21, 2019 23:57
@coilysiren coilysiren requested a review from a team as a code owner December 21, 2019 23:57
@coilysiren coilysiren requested review from rliebz and asahasrabuddhe and removed request for a team December 21, 2019 23:57
@asahasrabuddhe
Copy link
Member

This commit message is epic @lynncyrin appease gfmrun

Copy link
Member

@asahasrabuddhe asahasrabuddhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coilysiren coilysiren merged commit c7f0414 into master Dec 25, 2019
@coilysiren coilysiren deleted the lynncyrin-patch-8 branch December 25, 2019 16:49
@coilysiren coilysiren mentioned this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create documentation on how to use required flags
4 participants