Add required flags documentation #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d return map of missing flag names with matching bool for RequiredFlagsErr value
…ated functions to handle map
…change in RequiredFlag interface
Codecov Report
@@ Coverage Diff @@
## master #1008 +/- ##
======================================
Coverage 72.5% 72.5%
======================================
Files 33 33
Lines 2495 2495
======================================
Hits 1809 1809
Misses 575 575
Partials 111 111Continue to review full report at Codecov.
|
…e' into lynncyrin-patch-8 Co-authored-by: Aaron Berns <anberns@gmail.com>
coilysiren
force-pushed
the
lynncyrin-patch-8
branch
from
75b3bc4
to
bff6ec5
Compare
coilysiren
changed the title
coilysiren
requested review from
rliebz and
asahasrabuddhe
and removed request for
a team
saschagrunert
approved these changes
Dec 22, 2019
|
This commit message is epic @lynncyrin |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #961
Changes
Adds documentation for required flags
Testing
I had a little back and forth with
gfmrunwhile working on this 😄Additional Context
I merged #886 via @anberns into this PR, since I copy pasted some of the example from them ^^