Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Global* methods. #385

Closed
jszwedko opened this issue May 3, 2016 · 2 comments
Closed

Remove support for Global* methods. #385

jszwedko opened this issue May 3, 2016 · 2 comments
Assignees
@meatballhat
Labels
kind/feature describes a code enhancement / feature request
Milestone
v2.0.0

Comments

@jszwedko
Copy link
Contributor

jszwedko commented May 3, 2016

Instead, have the normal flag fetch methods always walk up the context hierarchy until they find their matching flag (or hit the root).
@jszwedko jszwedko added this to the v2.0.0 milestone May 3, 2016
@jszwedko jszwedko mentioned this issue May 3, 2016
Closed
@jszwedko
Copy link
Contributor Author

jszwedko commented May 3, 2016

See #191 (comment) for possible implementation of walking up the context tree.

@meatballhat meatballhat added the kind/feature describes a code enhancement / feature request label May 4, 2016
meatballhat added a commit that referenced this issue May 16, 2016
@meatballhat
Remove all Context.Global* methods
bef835d 
and change the behavior of the non-Global variants to always search up the
context lineage.

Closes #385
@meatballhat meatballhat mentioned this issue May 16, 2016
Merged
@codegangsta codegangsta added the status/claimed someone has claimed this issue label May 16, 2016
@jszwedko
Copy link
Contributor Author

jszwedko commented May 21, 2016 •
edited

Fixed in #410 (to be released in v2)

@codegangsta codegangsta removed the status/claimed someone has claimed this issue label May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meatballhat meatballhat

Labels
kind/feature describes a code enhancement / feature request
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@meatballhat @codegangsta @jszwedko