Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BoolTFlag #412

Closed
jszwedko opened this issue May 17, 2016 · 3 comments
Closed

Remove BoolTFlag #412

jszwedko opened this issue May 17, 2016 · 3 comments
Assignees
@meatballhat
Labels
kind/feature describes a code enhancement / feature request
Milestone
v2.0.0

Comments

@jszwedko
Copy link
Contributor

jszwedko commented May 17, 2016 •
edited
Loading

I think it is simpler to just Value to BoolFlag for the defaulting logic.
@jszwedko jszwedko added the kind/feature describes a code enhancement / feature request label May 17, 2016
@jszwedko jszwedko added this to the v2.0.0 milestone May 17, 2016
@meatballhat
Copy link
Member

Do you mean to add a Value member to the BoolFlag type?

@jszwedko
Copy link
Contributor Author

Haha, yeah, verbs are cool. I guess.

😄

meatballhat added a commit that referenced this issue May 18, 2016
@meatballhat
Replace BoolTFlag type with BoolFlag.Value
f2d5ed9 
Closes #412
@meatballhat meatballhat mentioned this issue May 18, 2016
Merged
1 task
@codegangsta codegangsta added the status/claimed someone has claimed this issue label May 18, 2016
@jszwedko
Copy link
Contributor Author

Fixed by #414 (to be released as v2)

@codegangsta codegangsta removed the status/claimed someone has claimed this issue label May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meatballhat meatballhat

Labels
kind/feature describes a code enhancement / feature request
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@meatballhat @codegangsta @jszwedko