Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was "eb027661af08a193a5f8a33528a44a80e9dc58ae" removed from master's history? #60

Closed
hiremaga opened this issue Jan 7, 2014 · 6 comments

Comments

@hiremaga
Copy link

hiremaga commented Jan 7, 2014

We noticed this in our CI:

cd /mnt/jenkins/jobs/tabasco-runtime-cf-deploy/workspace/gospace/src/github.com/codegangsta/cli; git pull --ff-only
fatal: Not possible to fast-forward, aborting.
package github.com/cloudfoundry-incubator/spiff
    imports github.com/cloudfoundry-incubator/spiff/compare
    imports github.com/cloudfoundry-incubator/spiff/yaml
    imports launchpad.net/goyaml
    imports github.com/cloudfoundry-incubator/spiff/dynaml
    imports github.com/cloudfoundry-incubator/spiff/flow
    imports github.com/codegangsta/cli: exit status 128
error: Command failed: "go get -u -v github.com/cloudfoundry-incubator/spiff" (options: {})    # 2014-01-06 23:37:14 +0000

The commit was:

commit eb027661af08a193a5f8a33528a44a80e9dc58ae
Merge: 1cb2291 69b5310
Author: Jeremy Saenz <jeremy.saenz@gmail.com>
Date:   Thu Jan 2 08:36:08 2014 -0800

    Merge pull request #58 from tjarratt/master

    Allow flags to omit their default value in String()
@hiremaga
Copy link
Author

hiremaga commented Jan 7, 2014

cc @vito

@codegangsta
Copy link
Contributor

Yes. This commit introduced a change that broke many repos. Unfortunately I found out about it while I was in vacation. I apologize for the inconvenience, the feature will hopefully make it in the repo in a different way

Sent from my iPhone

On Jan 6, 2014, at 5:01 PM, Abhi Hiremagalur notifications@github.com wrote:

cc @vito


Reply to this email directly or view it on GitHub.

@hiremaga
Copy link
Author

hiremaga commented Jan 7, 2014

Thanks for the clarification.

Any reason the commit wasn't reverted instead?

@hiremaga
Copy link
Author

hiremaga commented Jan 7, 2014

To clarify, it isn't the feature that we miss–it was git's history being re-written that confused go get -u

@codegangsta
Copy link
Contributor

Yeah, sorry about that guys, total mistake on my part. I will revert in the future :/

Sent from my iPhone

On Jan 6, 2014, at 5:17 PM, Abhi Hiremagalur notifications@github.com wrote:

To clarify, it isn't the feature that we miss–it was git's history being re-written that confused go get -u


Reply to this email directly or view it on GitHub.

@hiremaga
Copy link
Author

hiremaga commented Jan 7, 2014

No worries! Thanks for the super quick responses and for the project :)

On Monday, January 6, 2014, Jeremy Saenz wrote:

Yeah, sorry about that guys, total mistake on my part. I will revert in
the future :/

Sent from my iPhone

On Jan 6, 2014, at 5:17 PM, Abhi Hiremagalur <notifications@github.com<javascript:_e({}, 'cvml', 'notifications@github.com');>>
wrote:

To clarify, it isn't the feature that we miss–it was git's history being
re-written that confused go get -u


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHubhttps://github.com//issues/60#issuecomment-31705335
.

@hiremaga hiremaga closed this as completed Jan 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants