Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create question template #1019

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Create question template #1019

merged 2 commits into from
Jan 6, 2020

Conversation

coilysiren
Copy link
Member

Motivation

I'm really loving the templates, and think it would be helpful to encourage more issue like this one #1009

@coilysiren coilysiren requested a review from a team as a code owner December 27, 2019 11:45
@coilysiren coilysiren self-assigned this Dec 27, 2019
@coilysiren coilysiren requested review from rliebz and asahasrabuddhe and removed request for a team December 27, 2019 11:45
@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #1019 into master will increase coverage by 0.09%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1019      +/-   ##
=========================================
+ Coverage    72.5%   72.6%   +0.09%     
=========================================
  Files          33      33              
  Lines        2495    2482      -13     
=========================================
- Hits         1809    1802       -7     
+ Misses        575     569       -6     
  Partials      111     111
Impacted Files Coverage Δ
altsrc/map_input_source.go 52.85% <ø> (ø) ⬆️
context.go 95.45% <ø> (ø) ⬆️
app.go 78.71% <ø> (+1.54%) ⬆️
altsrc/flag_generated.go 64.28% <ø> (ø) ⬆️
altsrc/json_source_context.go 19.83% <0%> (ø) ⬆️
flag.go 86.22% <100%> (-0.06%) ⬇️
flag_int.go 70% <100%> (ø) ⬆️
flag_string.go 88.88% <100%> (ø) ⬆️
flag_duration.go 70% <100%> (ø) ⬆️
flag_int_slice.go 72.46% <100%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5737de6...3963383. Read the comment docs.

@coilysiren
Copy link
Member Author

here's another case where someone would have picked the question template 🙂 #1034

@coilysiren coilysiren merged commit 3b8f4b9 into master Jan 6, 2020
@coilysiren coilysiren deleted the lynncyrin-patch-1 branch January 6, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants