-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge altsrc with main package #1058
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ffb4663
Integrate altsrc in main package
asahasrabuddhe 6f56841
Fix test cases
asahasrabuddhe 466c9ce
Merge branch 'master' into alt-src-reorganization
asahasrabuddhe 2ff8978
Merge remote-tracking branch 'origin/master' into v3-alt-src
coilysiren d62f072
Merge branch 'master' into v3-alt-src
coilysiren c5f50db
Merge branch 'master' into v3-alt-src
coilysiren 1f19a1b
Merge branch 'master' into v3-alt-src
asahasrabuddhe aacc63a
fix imports
asahasrabuddhe 199d8a8
add missing refute function
asahasrabuddhe 6f0113f
fix gofmt for helpers_test
asahasrabuddhe 7e74963
change path to D: to support github actions
asahasrabuddhe 78f51b6
fix flag name prefixer test
asahasrabuddhe ce9974b
fix missing test cases and apply linter fixes
asahasrabuddhe ddb40f4
fix go imports
asahasrabuddhe 338d2e1
cleanup altsrc incoming code
asahasrabuddhe 120695c
enable actions on v3 development branch
asahasrabuddhe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ (nice to have) can we name this just
v3
? For the sake of consistency 🙏There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge deal either way, but I actually like having a name like
v3-development-master
that indicates a lack of stability compared tov3
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @rliebz it's just temporary. I will rename it once it's stable :)