Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to docs on v2 manual #1148

Merged
merged 1 commit into from Jun 16, 2020
Merged

fix link to docs on v2 manual #1148

merged 1 commit into from Jun 16, 2020

Conversation

tmatias
Copy link
Contributor

@tmatias tmatias commented Jun 15, 2020

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

the link was pointing to v1 docs

Which issue(s) this PR fixes:

(REQUIRED)

Release Notes

(REQUIRED)

NONE

was pointing to v1 docs
@tmatias tmatias requested a review from a team as a code owner June 15, 2020 15:06
@tmatias tmatias requested review from rliebz and asahasrabuddhe and removed request for a team June 15, 2020 15:06
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ✨

@coilysiren coilysiren merged commit 4f74020 into urfave:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants