Fix v1 aliases syntax in v2 docs #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemzale
requested review from
saschagrunert and
coilysiren
and removed request for
a team
coilysiren
requested changes
Aug 17, 2020
There was a problem hiding this comment.
@zemzale the code change more or less LGTM, but it looks like the docs tests are failing. Can you look into that and then re-request my review?
|
Fixed the failing docs. Somehow I added one too many brackets where it shouldn't be. |
rliebz
approved these changes
Aug 26, 2020
|
bump |
|
@lynncyrin if you get the chance to take another look here, should be an easy one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Fix issue with v1 type aliases syntax in v2 documentation that might cause confusion.
Which issue(s) this PR fixes:
Fixes #1172