Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude hidden sub-command flags from docs #1346

Merged
merged 1 commit into from Apr 26, 2022

Conversation

jolheiser
Copy link
Contributor

@jolheiser jolheiser commented Apr 19, 2022

What type of PR is this?

  • bug

What this PR does / why we need it:

Not sure I would hard-classify this as a "bug" per-se, but it expands on #999 by also excluding flags marked as hidden in sub-commands for docs generation.

Which issue(s) this PR fixes:

Expands upon #999

Testing

I've changed docs_test.go and go test ./... passes.

Release Notes

NONE

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser requested a review from a team as a code owner Apr 19, 2022
@meatballhat meatballhat added kind/bug describes or fixes a bug area/v2 relates to / is being considered for v2 labels Apr 21, 2022
@meatballhat meatballhat added this to the Release 2.5.0 milestone Apr 21, 2022
@meatballhat meatballhat changed the base branch from master to main Apr 21, 2022
Copy link
Member

@meatballhat meatballhat left a comment

Thank you! 🎉

@meatballhat meatballhat merged commit 924052a into urfave:main Apr 26, 2022
12 checks passed
@jolheiser jolheiser deleted the hidden-flag branch Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/bug describes or fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants