Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run docs tests against current work tree #1403

Merged
merged 2 commits into from May 23, 2022
Merged

Run docs tests against current work tree #1403

merged 2 commits into from May 23, 2022

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented May 23, 2022

What type of PR is this?

  • bug
  • documentation

What this PR does / why we need it:

This change ensures the docs tests are run against the current work tree by creating a temporary go workspace to be used by gfmrun via TMPDIR.

Which issue(s) this PR fixes:

N/A 馃槵

by creating a temporary go workspace to be used by gfmrun via `TMPDIR`.
@meatballhat meatballhat added kind/bug describes or fixes a bug kind/documentation describes a documentation update area/v2 relates to / is being considered for v2 labels May 23, 2022
@meatballhat meatballhat added this to the Release 2.x milestone May 23, 2022
@meatballhat meatballhat marked this pull request as ready for review May 23, 2022
@meatballhat meatballhat requested a review from a team as a code owner May 23, 2022
mostynb
mostynb previously approved these changes May 23, 2022
internal/build/build.go Outdated Show resolved Hide resolved
and slightly revert assertion in docs test to ensure flag ordering
@meatballhat meatballhat merged commit 595cabc into main May 23, 2022
13 checks passed
@meatballhat meatballhat deleted the gfmrun-current branch May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/v2 relates to / is being considered for v2 kind/bug describes or fixes a bug kind/documentation describes a documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants