Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve v2 addition of App.DefaultCommand #1426

Merged
merged 1 commit into from Jul 10, 2022
Merged

Conversation

meatballhat
Copy link
Member

@meatballhat meatballhat commented Jun 24, 2022

What type of PR is this?

  • cleanup
  • documentation

Which issue(s) this PR fixes:

related to #1388

@meatballhat meatballhat requested a review from a team as a code owner Jun 24, 2022
@meatballhat meatballhat added kind/documentation describes a documentation update kind/cleanup describes internal cleanup / maintaince labels Jun 24, 2022
@meatballhat meatballhat added this to the Release 2.x milestone Jun 24, 2022
@jalavosus
Copy link
Contributor

jalavosus commented Jun 24, 2022

The only thing I want to do -- and will work on when able -- before merging into a release is improving test coverage a bit. Some of my changes, while functional and passing tests I threw at them, were reported as uncovered by CodeCov in #1388.

@meatballhat
Copy link
Member Author

meatballhat commented Jun 24, 2022

@jalavosus Understood! Are you OK with this pr getting merged ahead of your test coverage? And do you want to set a timeout on your work landing before next release?

@meatballhat meatballhat merged commit 8b41988 into main Jul 10, 2022
13 checks passed
@meatballhat meatballhat deleted the default-command-doc branch Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup describes internal cleanup / maintaince kind/documentation describes a documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants