Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate all App code into Command #1746

Merged
merged 26 commits into from
Jun 13, 2023
Merged

Consolidate all App code into Command #1746

merged 26 commits into from
Jun 13, 2023

Commits on Jun 2, 2023

  1. Consolidate all App code into Command 

    Closes #1586
    @meatballhat
    meatballhat committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    a1149b5 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2023

  1. Fixing some of the tests

    @meatballhat
    meatballhat committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    f3e0f77 View commit details
    Browse the repository at this point in the history

  2. Fixing more tests around combining App and Command

    @meatballhat
    meatballhat committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    58923b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Merge remote-tracking branch 'origin/main' into app-command-collapse-… 

    …again
    @meatballhat
    meatballhat committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    0e4bfae View commit details
    Browse the repository at this point in the history

  2. Fixing more tests and panics

    @meatballhat
    meatballhat committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    f0abc82 View commit details
    Browse the repository at this point in the history

  3. Remove App type

    @meatballhat
    meatballhat committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    35a2755 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Fixing some tests, giving up (for now) on others 

    includes adding internal `tracef` func
    @meatballhat
    meatballhat committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    adf81a2 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Fix a few more tests and break many others

    @meatballhat
    meatballhat committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9005335 View commit details
    Browse the repository at this point in the history

  2. Fix (break) a few examples

    @meatballhat
    meatballhat committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    5a9784a View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Mostly fixing things this time

    @meatballhat
    meatballhat committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    eea2adc View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Fix or skip remaining tests 

    plus delete accidentally-added binary
    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    f2fe61c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into app-command-collapse-… 

    …again
    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    8e5598f View commit details
    Browse the repository at this point in the history

  3. Fix flag action test after merge

    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    c72fa02 View commit details
    Browse the repository at this point in the history

  4. Fix some golangci-lint bits

    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    76f538b View commit details
    Browse the repository at this point in the history

  5. Cleanups around App ➡️ Command collapse 

    including removal of the `Commands` slice type, replacing the
`Command.HelpName` field with a `Command.FullName()` method
    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e0b109c View commit details
    Browse the repository at this point in the history

  6. Function receiver naming consistency, adding Command.Root()

    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    2eac7ce View commit details
    Browse the repository at this point in the history

  7. Re-introduce optional command in help templates

    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e58ad0b View commit details
    Browse the repository at this point in the history

  8. Promote docs changes

    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    0171f96 View commit details
    Browse the repository at this point in the history

  9. Start moving examples into separate file 

    and separate test package to ensure public API usage
    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    412c9a7 View commit details
    Browse the repository at this point in the history

  10. Move remaining Example funcs to examples_test.go

    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    c6eb55c View commit details
    Browse the repository at this point in the history

  11. Move remaining previously-App tests to command_test.go 

    and remove duplicates
    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    ccbd7d8 View commit details
    Browse the repository at this point in the history

  12. Remove CommandsByName type 

    because it is not used internally anymore
    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    a0eae69 View commit details
    Browse the repository at this point in the history

  13. Add and use test helper for building context.Context

    @meatballhat
    meatballhat committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    008c169 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Changes per feedback on #1746

    @meatballhat
    meatballhat committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    841adc7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into app-command-collapse-… 

    …again
    @meatballhat
    meatballhat committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    6909910 View commit details
    Browse the repository at this point in the history

  3. Approve v3 API change

    @meatballhat
    meatballhat committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    c613e65 View commit details
    Browse the repository at this point in the history