-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hidden flags #181
Add hidden flags #181
Conversation
This feature is definitely a help to us for shipping products where some features are unlikely to be used by the end user (but we use them internally), ideally there would be a |
👍 |
I understand the motivation for a feature like this, but this could also be accomplished by checking for an environment variable and conditionally adding flags in the source (e.g. looking for |
@jszwedko perhaps this is not how you design your applications, but I would assume for most the app.Run() is their first entry point, to establish the environment within which the application will execute, creating a separate pre-run step that also establishes the environment seems like duplication of effort |
@termie sure, but it doesn't need to be. The main entry point is always |
Oh wow, i should have seen this PR before i just submitted - #201 .. damn! , how quickly will this be merged? |
Improved upon #201 with filtering flags at higher level than 'templates' so that we don't end up with odd formatting issues. This way we don't also have to keep Also by default |
+1 |
This is similar to #180, but then applied to flags. Implementation is done similar to #155