remove the possiblity of end-user's seeing deprecation warnings #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead use deprecation pattern described in https://blog.golang.org/godoc-documenting-go-code. Fixes #507
|
If we like this, I can backport it the released versions since 1.15.0. |
meatballhat
added
the
kind/feature
|
Thanks, that works much better for me now. I had problems updating with both Gin (the web server) and CLI last weekend. However, despite two grumpy bug reports both projects have responded politely and fast. My apologies for the tone of my bug report and many thanks for providing CLI. |
|
🎷 🐻 |
|
No worries, thank you too, @alienscience |
jszwedko
added a commit
that referenced
this pull request
Aug 29, 2016
jszwedko
added a commit
that referenced
this pull request
Aug 29, 2016
jszwedko
added a commit
that referenced
this pull request
Aug 29, 2016
jszwedko
added a commit
that referenced
this pull request
Nov 12, 2016
jszwedko
added a commit
that referenced
this pull request
Nov 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead use deprecation pattern described in
https://blog.golang.org/godoc-documenting-go-code.
This will reduce the chances that the application developer will notice that
the deprecations, but I can see the argument that @alienscience is making in
#507 that the current approach is actually an API breakage rather than
a deprecation since the warnings are printed at runtume. More practically, this
has a chance to create a poor user experience for users of applications that
use
cliif the application developer doesn't notice the warnings.Fixes #507