Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-curated L2 Topic and Tag Pages #251

Closed
benpeter opened this issue Mar 11, 2024 · 4 comments · Fixed by #258
Closed

Non-curated L2 Topic and Tag Pages #251

benpeter opened this issue Mar 11, 2024 · 4 comments · Fixed by #258
Assignees
Milestone

Comments

@benpeter
Copy link
Collaborator

benpeter commented Mar 11, 2024

Figma doesn't currently include an example of a non-curated Topic Page.
An example would be https://main--hlx-test--urfuwo.hlx.page/topics/ai which is currently off in terms of styling.

Tasks:

  1. create a template that is a reasonable representation for non-curated Topic Pages (authoring team can later change the template, just needs to look OK)

  2. create shared side navigation for 2 sample topic groups and map that side navigation through the metadata sheet

  • use topic group sustainbability, sub topics of green software development, carbon accounting for an example
  • all other topics don't use a side navigation (meaning L2 needs to work without a side nav)
@benpeter benpeter added this to the Mid-March presentation milestone Mar 11, 2024
@benpeter benpeter changed the title Fix non-curated L2 Topic Pages Fix non-curated L2 Topic and Tag Pages Mar 11, 2024
@pahupe
Copy link
Contributor

pahupe commented Mar 11, 2024

Related to #250

@pahupe pahupe self-assigned this Mar 12, 2024
@pahupe
Copy link
Contributor

pahupe commented Mar 12, 2024

Will be done in one go with #250

@pahupe pahupe changed the title Fix non-curated L2 Topic and Tag Pages Non-curated L2 Topic and Tag Pages Mar 12, 2024
@pahupe
Copy link
Contributor

pahupe commented Mar 12, 2024

Requires the #250 PR (#258) to be merged, as the code changes are in #250.

Default for topics and tags (as they are L2 pages) is:

  • side nav is there per default (default as required by design team)
  • pages can choose to have no sidenav

Topic pages:

Tag pages:

@pahupe
Copy link
Contributor

pahupe commented Mar 12, 2024

Replaced with #250 and PR #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 👏🏻
2 participants