Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Changed logo in samples to fish bone logo #1719

Closed
wants to merge 2 commits into from
Closed

Changed logo in samples to fish bone logo #1719

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 18, 2016

No description provided.

@ghost ghost changed the title Changed logo in samples to fishbone logo Changed logo in samples to fish bone logo Dec 18, 2016
@cadaver
Copy link
Contributor

cadaver commented Dec 18, 2016

Cool, will check.

@cadaver
Copy link
Contributor

cadaver commented Dec 18, 2016

Works well and is power-of-two so no trouble on mobiles. Lua implementation was missing but I can add it before merging.

@weitjong Was this variant of the logo OK for you? (the one with thick green outline and black edge outline)

@weitjong
Copy link
Contributor

Thanks for asking. I have stated my preferences in the forum. Having said that, I am fine with this one too, if you are OK with it.

@cadaver
Copy link
Contributor

cadaver commented Dec 18, 2016

I will meditate on these a bit.

EDIT: Yeah, I can see the black/white one being better in general use. (As well as being more corpse-like.) The green is nice in the demos on a large display, but it could easily turn into a smudge when downsized. I'll replace with your preference, and 1vanK liked the same too.

@cadaver
Copy link
Contributor

cadaver commented Dec 18, 2016

Black/white version of fish bone logo (urho3d_nofin) has been put in, with svg source put to SourceAssets.

By me it's now fine if this logo replaces the old everywhere.

@cadaver cadaver closed this Dec 18, 2016
@ghost
Copy link
Author

ghost commented Dec 18, 2016

I must say I like the dark green outline way better. Especially in the samples. To me it was quite obvious that version was the one to go with.
Also the green version was no option yet, the last time anyone shared their preference. In my view I only improved the version/shape preference was spoken out about, to make it work on a black surface and with it added a bit of (voodoo) life that the previous logo was so full of.
I'd say both have their place. But in the samples it should most certainly be the one with colour.

@1vanK
Copy link
Contributor

1vanK commented Dec 18, 2016

I continue to believe that simple black-and-white version better suited for logotype. Just my opinion.

@ghost
Copy link
Author

ghost commented Dec 18, 2016

For among text, like in the readme? I think I agree.

@1vanK
Copy link
Contributor

1vanK commented Dec 18, 2016

no, I chose as a logo, which will be on the site, on splash screen, etc.

@ghost
Copy link
Author

ghost commented Dec 18, 2016

Have you tried both on a black background?

@1vanK
Copy link
Contributor

1vanK commented Dec 18, 2016

no

@1vanK
Copy link
Contributor

1vanK commented Dec 18, 2016

On black background (splashscreen) i will use inverted image (white contour)

@ghost
Copy link
Author

ghost commented Dec 18, 2016

Tried that. Doesn't look as good if you ask me. It gets better with a thinner outline though, but still.

@1vanK
Copy link
Contributor

1vanK commented Dec 18, 2016

may be make some vote?

@1vanK
Copy link
Contributor

1vanK commented Dec 18, 2016

May be add both variants? Colored for samples and BW for logo?

@ghost
Copy link
Author

ghost commented Dec 18, 2016

Logo comparison

@ghost
Copy link
Author

ghost commented Dec 18, 2016

Ok, maybe the coloured version could use a little slimming down with the extra outline:
Slimmed down logo

Created a new PR: #1722

@ghost ghost deleted the new-logo branch December 18, 2016 21:33
@weitjong weitjong added the улучшение Улучшение существующих вещей label Jan 7, 2017
@weitjong weitjong added this to the 1.7 milestone Oct 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
улучшение Улучшение существующих вещей
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants