Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec-examples.json is missing cases #44

Open
GrahamCampbell opened this issue Jul 12, 2020 · 2 comments
Open

spec-examples.json is missing cases #44

GrahamCampbell opened this issue Jul 12, 2020 · 2 comments

Comments

@GrahamCampbell
Copy link

The readme says that all the cases from spec-examples-by-section.json are included in the spec-examples.json file, but this is not true. There are various missing examples.

@mnot
Copy link
Member

mnot commented Jan 18, 2022

Can you be more specific?

@kolektiv
Copy link

kolektiv commented Jul 29, 2023

As I'm currently implementing Yet Another URI Template Parser as part of a broader piece, I've found a few gaps/challenges for the unsuspecting implementer. In this case, I'm also not 100% sure which test cases should be in which file, and to what extent they overlap or are super/sub sets of each other.

Looking at spec-examples.json, is it supposed to represent all cases of a specific level in the RFC, or just those cases detailed in the table in 1.2? It seems to be the latter, with a few missing cases (the fragment expansion examples from Level 2, a label expansion example (X{.keys*}) from Level 4) and the occasional added case (an errata-exercising case in Level 1 including "'" as an allowed literal character).

If it is meant to be just the examples given in the example table, with the rest of the examples in the RFC included in the section-specific spec-examples-by-section.json (and thus the union of the two being all test cases), would it be worth changing the wording in the README to make this clearer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants