-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomplete test coverage for UriFile.c #16
Comments
Hi Kurt, uriparser currently relies on more-or-less-end-of-life cpptest. For a path into the future, I would like to see the current test suite code turn to something more alive (like GoogleTest) to then increase coverage further. If you can tell more about your use and goals with uriparser at Google — in a private mail or just up here — it would help me to understand the bigger picture better. Is that possible? Thanks and best, Sebastian |
Inside Google we have one main use of uriparser... It's used by libkml. We are switching to the community fork of libkml to have it be the primary fork. My main goal is to be able to patch from upstream with reasonable reliability. a.k.a. decent test and fuzzer coverage. You are welcome to all of the GoogleTest files that I have so far |
uriparser is now using GoogleTest on |
Taking a quick peak at the tests, I have a minor suggestion for the future (no rush): The usual strategy is to use EXPECT* rather than ASSERT* for most things That way when something goes sideways, more of the tests get run and you as the debugger get to see more tests results. Sometimes a later test will make the issue more obvious. You then use ASSERT* to block forward progress when continuing on makes no sense. For example, you initialize some datastructure with a call and use |
I see, I'll keep that in mind. Thanks! |
I redid the tests for
UriFile.c
for my own use in GoogleTest. In doing so, I noticed thattest.cpp
doesn't fully cover the compilation unit. You are welcome to take any of my test code and adapt for uriparser. If you aren't interested in the coverage, feel free to close the issue.The checks with CheckUriUriStringToWindowsFilenameA are bit chaotic and could use some improvement. The code is only tested with ASCII input as I don't build with wchar_t support.
I do one test file for each compilation unit rather than a catch all test.cpp.
Code is copyright Google and donated to uriparser under the uriparser license.
Here is what I have:
The text was updated successfully, but these errors were encountered: