Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt: fix build without C++ #69

Closed
wants to merge 1 commit into from
Closed

CMakeLists.txt: fix build without C++ #69

wants to merge 1 commit into from

Conversation

ffontaine
Copy link
Contributor

Specify that uriparser is a C project (C++ is needed only for the test
runner) otherwise build will fail if no C++ compiler is found by cmake

Fixes:

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

@hartwork
Copy link
Member

hartwork commented May 1, 2019

Hi @ffontaine , thanks for taking this upstream!

What concerns me a bit right now is that the proposed change affects all targets — including the C++ testrunner target — rather than just the library and commend line tool. Is there a way to make the list of languages depend on URIPARSER_BUILD_TESTS or to set it per target rather than for the whole project?

Thanks!

@hartwork hartwork self-assigned this May 1, 2019
@arnout
Copy link

arnout commented May 1, 2019

To enable C++ for the testrunner target you can use the ENABLE_LANGUAGE command within the condition that enables the testrunner.

@ffontaine
Copy link
Contributor Author

Thanks @arnout, I'll test it and update my PR.

Specify that uriparser is a C project (C++ is needed only for the test
runner) otherwise build will fail if no C++ compiler is found by cmake

Fixes:
 - http://autobuild.buildroot.org/results/1e191676f28905a81de6282e07978aa5d4f02039

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
hartwork added a commit that referenced this pull request Jun 10, 2019
@hartwork hartwork closed this in 70c92bb Jun 10, 2019
@hartwork
Copy link
Member

@ffontaine I found a way now to get AppVeyor CI happy. The problem was the CXX build flags were modified before CXX support was enabled (since it's happening a lot later now). cb0001d addresses that which allowed to merge your changes into master now. Thanks for your contribution to uriparser!

@hartwork hartwork added this to the 0.9.4 milestone Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants