This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Update moment.js version #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to help with `nsp` check failing, specifically for https://nodesecurity.io/advisories/532
Update moment.js version
|
@urish can you please have a look at this, it's causing builds depending on |
|
Hi, thank you for the PR! |
|
@urish it's based of off the NSP CVE (https://nodesecurity.io/advisories/532). What was happening was that a ReDoS had slipped through, and builds would fail (see screenshot). It was fixed via pull request moment/moment#4326 with the issue logged on moment/moment#4163 |
|
Got it, thanks |
|
Released as 1.2.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help with
nspcheck failing, specifically for https://nodesecurity.io/advisories/532