Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

added scope eval to allow for data binding support #21

Merged
merged 1 commit into from
Oct 17, 2014

Conversation

jdamick
Copy link
Contributor

@jdamick jdamick commented Jul 14, 2014

Added support for eval'ing the active flag so you can bind scope attributes. Also added associated tests.

@jdamick
Copy link
Contributor Author

jdamick commented Jul 29, 2014

Unfortunately the merge from trunk has left this broken, once trunk is fixed i'll remerge and this will be fixed..

@urish
Copy link
Owner

urish commented Jul 29, 2014

Yup, something is broken there. I will take a look... Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling dbb60c0 on jdamick:active-flag-enhancement into 0b1ea5b on urish:master.

@jdamick
Copy link
Contributor Author

jdamick commented Oct 16, 2014

finally came back around to this, can you please merge?

@magwo
Copy link

magwo commented Oct 17, 2014

Please merge - this is a very good feature.

urish added a commit that referenced this pull request Oct 17, 2014
added scope eval to allow for data binding support
@urish urish merged commit 73e766c into urish:master Oct 17, 2014
@urish
Copy link
Owner

urish commented Oct 17, 2014

Thanks! I guess this changes the previous behavior a little, doesn't it?

@urish urish mentioned this pull request Dec 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants