This repository has been archived by the owner on Oct 1, 2023. It is now read-only.
Bugfix: Stop events are ignored if sent before the directive is fully initialized and startActive is true
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When startactive is true. We can send a stop event before initialization. Then the spin rotates indefinitely. I deactivated the startactive during the stop event to prevent this behavior
|
Thanks! |
urish
added a commit
that referenced
this pull request
Aug 9, 2014
…ialization bug introduced by #22 and broke tests.
urish
changed the title
startActive is true
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When startactive is true. We can send a stop event before initialization. Then the spin rotates indefinitely. I deactivated the startactive during the stop event to prevent this behavior