This repository has been archived by the owner on Oct 1, 2023. It is now read-only.
fix(usSpinnerConfig): fix problem with default options overwriting #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spinner initialization Fix problem when default options of usSpinnerConfig are overwritten by theme options and/or spinner options due to incorrect usage of angular.extend.
urish
added a commit
that referenced
this pull request
Jan 10, 2016
…ting fix(usSpinnerConfig): fix problem with default options overwriting
|
great, thanks! |
|
@urish Could you please cut a release with this fix? |
|
I will |
|
Released as 0.8.1 |
|
@urish Awesome. Many thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix problem when default options of usSpinnerConfig are overwritten by theme options and/or spinner options due to incorrect usage of angular.extend.
Fix #76
And it fixes the same problem as #78 does, but this one has tests.